Skip to content

Commit d0452cd

Browse files
committed
✨ Refactor test API service access: simplify mock patching for ServicesRepository
1 parent 66504b5 commit d0452cd

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

services/catalog/tests/unit/with_dbs/test_api_rest_services_ports.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ async def mocked_check_service_read_access(
5454
assert user_groups_ids
5555

5656
mocker.patch.object(
57-
simcore_service_catalog.api._dependencies.services,
58-
"ServicesRepository.get_service",
57+
simcore_service_catalog.api._dependencies.services.ServicesRepository,
58+
"get_service",
5959
autospec=True,
6060
return_value=True,
6161
)

services/catalog/tests/unit/with_dbs/test_core_background_task__sync.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from typing import Any
1010

1111
import pytest
12+
import simcore_service_catalog.service.access_rights
1213
from fastapi import FastAPI, HTTPException, status
1314
from pytest_mock import MockerFixture
1415
from respx.router import MockRouter
@@ -58,8 +59,9 @@ async def test_registry_sync_task(
5859

5960
if director_fails:
6061
# Emulates issue https://github.com/ITISFoundation/osparc-simcore/issues/6318
61-
mocker.patch(
62-
"simcore_service_catalog.services.access_rights._is_old_service",
62+
mocker.patch.object(
63+
simcore_service_catalog.service.access_rights,
64+
"_is_old_service",
6365
side_effect=HTTPException(
6466
status_code=status.HTTP_404_NOT_FOUND, detail="fake director error"
6567
),

0 commit comments

Comments
 (0)