add test

Author: giancarloromeo

services/web/server/src/simcore_service_webserver/api_keys/_api.py

@@ -10,6 +10,7 @@
 from servicelib.utils_secrets import generate_token_secret_key
 
 from . import _db
+from .errors import ApiKeyNotFoundError
 
 _PUNCTUATION_REGEX = re.compile(
     pattern="[" + re.escape(string.punctuation.replace("_", "")) + "]"
@@ -69,11 +70,14 @@ async def create_api_key(
 
 async def get_api_key(
     app: web.Application, *, api_key_id: int, user_id: UserID, product_name: ProductName
-) -> ApiKeyGet | None:
-    row = await _db.get(
+) -> ApiKeyGet:
+    api_key = await _db.get(
         app, api_key_id=api_key_id, user_id=user_id, product_name=product_name
     )
-    return ApiKeyGet.model_validate(row) if row else None
+    if api_key is not None:
+        return ApiKeyGet.model_validate(api_key) if api_key else None
+
+    raise ApiKeyNotFoundError(api_key_id=api_key_id)
 
 
 async def get_or_create_api_key(

services/web/server/src/simcore_service_webserver/api_keys/errors.py

@@ -6,4 +6,4 @@ class ApiKeysValueError(WebServerBaseError, ValueError):
 
 
 class ApiKeyNotFoundError(ApiKeysValueError):
-    msg_template = "API key not found. {reason}"
+    msg_template = "API Key with ID '{api_key_id}' not found. {reason}"

services/web/server/tests/unit/with_dbs/01/test_api_keys.py

@@ -7,6 +7,7 @@
 from collections.abc import AsyncIterable
 from datetime import timedelta
 from http import HTTPStatus
+from http.client import HTTPException
 
 import pytest
 import simcore_service_webserver.api_keys._db as db
@@ -201,3 +202,21 @@ async def test_get_or_create_api_key(
                 await get_or_create_api_key(client.app, **options | {"name": "foo"})
                 == created
             )
+
+
+@pytest.mark.parametrize(
+    "user_role,expected",
+    _get_user_access_parametrizations(status.HTTP_404_NOT_FOUND),
+)
+async def test_api_key_does_not_exists(
+    client: TestClient,
+    logged_user: UserInfoDict,
+    user_role: UserRole,
+    expected: HTTPException,
+    disable_gc_manual_guest_users: None,
+):
+    resp = await client.get("/v0/auth/api-keys/42")
+    data, errors = await assert_status(resp, expected)
+
+    if not errors:
+        assert data is None