doc

Author: pcrespov

.env-devel

@@ -77,7 +77,7 @@ DIRECTOR_LOGLEVEL=INFO
 DIRECTOR_MONITORING_ENABLED=True
 DIRECTOR_PORT=8000
 DIRECTOR_PUBLISHED_HOST_NAME="127.0.0.1:9081"
-DIRECTOR_REGISTRY_CACHING_TTL=900
+DIRECTOR_REGISTRY_CACHING_TTL=00:15:00
 DIRECTOR_REGISTRY_CACHING=True
 DIRECTOR_SERVICES_CUSTOM_CONSTRAINTS=null
 DIRECTOR_TRACING={}

services/director/src/simcore_service_director/core/settings.py

@@ -3,16 +3,10 @@
 from typing import cast
 
 from fastapi import FastAPI
-from models_library.basic_types import (
-    BootModeEnum,
-    BuildTargetEnum,
-    LogLevel,
-    PortInt,
-    VersionTag,
-)
-from pydantic import Field, NonNegativeInt, PositiveInt, validator
+from models_library.basic_types import LogLevel, PortInt, VersionTag
+from pydantic import Field, NonNegativeInt, validator
 from servicelib.logging_utils_filtering import LoggerName, MessageSubstring
-from settings_library.base import BaseCustomSettings
+from settings_library.application import BaseApplicationSettings
 from settings_library.docker_registry import RegistrySettings
 from settings_library.postgres import PostgresSettings
 from settings_library.tracing import TracingSettings
@@ -21,32 +15,11 @@
 from .._meta import API_VERSION, API_VTAG, APP_NAME
 
 
-class ApplicationSettings(BaseCustomSettings, MixinLoggingSettings):
-    # CODE STATICS ---------------------------------------------------------
+class ApplicationSettings(BaseApplicationSettings, MixinLoggingSettings):
     API_VERSION: str = API_VERSION
     APP_NAME: str = APP_NAME
     API_VTAG: VersionTag = API_VTAG
 
-    # IMAGE BUILDTIME ------------------------------------------------------
-    # @Makefile
-    SC_BUILD_DATE: str | None = None
-    SC_BUILD_TARGET: BuildTargetEnum | None = None
-    SC_VCS_REF: str | None = None
-    SC_VCS_URL: str | None = None
-
-    # @Dockerfile
-    SC_BOOT_MODE: BootModeEnum | None = None
-    SC_BOOT_TARGET: BuildTargetEnum | None = None
-    SC_HEALTHCHECK_TIMEOUT: PositiveInt | None = Field(
-        None,
-        description="If a single run of the check takes longer than timeout seconds "
-        "then the check is considered to have failed."
-        "It takes retries consecutive failures of the health check for the container to be considered unhealthy.",
-    )
-    SC_USER_ID: int | None = None
-    SC_USER_NAME: str | None = None
-
-    # RUNTIME  -----------------------------------------------------------
     DIRECTOR_DEBUG: bool = Field(
         default=False, description="Debug mode", env=["DIRECTOR_DEBUG", "DEBUG"]
     )

services/director/src/simcore_service_director/registry_proxy.py

@@ -42,6 +42,11 @@
 
 logger = logging.getLogger(__name__)
 
+#
+# NOTE: if you are refactoring this module,
+# please consider reusing packages/pytest-simcore/src/pytest_simcore/helpers/docker_registry.py
+#
+
 
 class ServiceType(enum.Enum):
     ALL = ""
@@ -375,10 +380,11 @@ async def get_image_details(
 async def get_repo_details(app: FastAPI, image_key: str) -> list[dict[str, Any]]:
 
     image_tags = await list_image_tags(app, image_key)
+
     results = await limited_gather(
         *[get_image_details(app, image_key, tag) for tag in image_tags],
         reraise=False,
-        _logger=logger,
+        log=logger,
         limit=_MAX_CONCURRENT_CALLS,
     )
     return [result for result in results if not isinstance(result, BaseException)]
@@ -400,7 +406,7 @@ async def list_services(app: FastAPI, service_type: ServiceType) -> list[dict]:
     results = await limited_gather(
         *[get_repo_details(app, repo) for repo in repos],
         reraise=False,
-        _logger=logger,
+        log=logger,
         limit=_MAX_CONCURRENT_CALLS,
     )