fixes test

Author: pcrespov

services/web/server/tests/unit/with_dbs/03/test_users_rest_profiles.py

@@ -11,7 +11,7 @@
 from copy import deepcopy
 from http import HTTPStatus
 from typing import Any
-from unittest.mock import MagicMock, Mock
+from unittest.mock import patch
 
 import pytest
 from aiohttp.test_utils import TestClient
@@ -544,28 +544,6 @@ async def test_update_existing_user_name(
     await assert_status(resp, status.HTTP_409_CONFLICT)
 
 
-@pytest.fixture
-def mock_failing_database_connection(mocker: Mock) -> MagicMock:
-    """
-    async with engine.acquire() as conn:
-        await conn.execute(query)  --> will raise OperationalError
-    """
-    # See http://initd.org/psycopg/docs/module.html
-    conn_execute = mocker.patch.object(SAConnection, "execute")
-    conn_execute.side_effect = OperationalError(
-        "MOCK: server closed the connection unexpectedly"
-    )
-
-    aysncpg_conn_execute = mocker.patch.object(AsyncConnection, "execute")
-    aysncpg_conn_execute.side_effect = SQLAlchemyOperationalError(
-        statement="MOCK statement",
-        params=(),
-        orig=OperationalError("MOCK: server closed the connection unexpectedly"),
-    )
-
-    return conn_execute
-
-
 @pytest.mark.parametrize(
     "user_role,expected",
     [
@@ -575,7 +553,6 @@ def mock_failing_database_connection(mocker: Mock) -> MagicMock:
 async def test_get_profile_with_failing_db_connection(
     logged_user: UserInfoDict,
     client: TestClient,
-    mock_failing_database_connection: MagicMock,
     expected: HTTPStatus,
 ):
     """
@@ -594,8 +571,22 @@ async def test_get_profile_with_failing_db_connection(
     url = client.app.router["get_my_profile"].url_for()
     assert str(url) == "/v0/me"
 
-    resp = await client.get(url.path)
-
-    data, error = await assert_status(resp, expected)
-    assert not data
-    assert error["message"] == "Authentication service is temporary unavailable"
+    with patch.object(SAConnection, "execute") as mock_sa_execute, patch.object(
+        AsyncConnection, "execute"
+    ) as mock_async_execute:
+
+        # Emulates a database connection failure
+        mock_sa_execute.side_effect = OperationalError(
+            "MOCK: server closed the connection unexpectedly"
+        )
+        mock_async_execute.side_effect = SQLAlchemyOperationalError(
+            statement="MOCK statement",
+            params=(),
+            orig=OperationalError("MOCK: server closed the connection unexpectedly"),
+        )
+
+        resp = await client.get(url.path)
+
+        data, error = await assert_status(resp, expected)
+        assert not data
+        assert error["message"] == "Authentication service is temporary unavailable"