Skip to content

Commit d16886c

Browse files
committed
refactor
1 parent e03b40e commit d16886c

File tree

2 files changed

+38
-32
lines changed

2 files changed

+38
-32
lines changed

services/static-webserver/client/source/class/osparc/desktop/MainPage.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ qx.Class.define("osparc.desktop.MainPage", {
9595
const pollTasks = osparc.store.PollTasks.getInstance();
9696
const exportDataTasks = pollTasks.getExportDataTasks();
9797
exportDataTasks.forEach(task => {
98-
osparc.task.ExportData.exportDataTaskReceived(task);
98+
osparc.task.ExportData.exportDataTaskReceived(task, false);
9999
});
100100
},
101101

services/static-webserver/client/source/class/osparc/task/ExportData.js

Lines changed: 37 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -28,41 +28,50 @@ qx.Class.define("osparc.task.ExportData", {
2828
statics: {
2929
ICON: "@FontAwesome5Solid/download",
3030

31-
exportDataTaskReceived: function(task) {
31+
exportDataTaskReceived: function(task, popUpProgressWindow = true) {
3232
const exportDataTaskUI = new osparc.task.ExportData();
3333
exportDataTaskUI.setTask(task);
3434
osparc.task.TasksContainer.getInstance().addTaskUI(exportDataTaskUI);
3535

36-
const progressWindow = new osparc.ui.window.Progress(
37-
qx.locale.Manager.tr("Downloading files"),
38-
osparc.task.ExportData+"/14",
39-
qx.locale.Manager.tr("Compressing files..."),
40-
);
41-
if (task.getAbortHref()) {
42-
const cancelButton = progressWindow.addCancelButton();
43-
cancelButton.setLabel(qx.locale.Manager.tr("Ignore"));
44-
const abortButton = new qx.ui.form.Button().set({
45-
label: qx.locale.Manager.tr("Cancel"),
46-
center: true,
47-
minWidth: 100,
48-
});
49-
abortButton.addListener("execute", () => task.abortRequested());
50-
progressWindow.addButton(abortButton);
51-
abortButton.set({
52-
appearance: "danger-button",
36+
if (popUpProgressWindow) {
37+
const progressWindow = new osparc.ui.window.Progress(
38+
qx.locale.Manager.tr("Downloading files"),
39+
osparc.task.ExportData+"/14",
40+
qx.locale.Manager.tr("Compressing files..."),
41+
);
42+
43+
if (task.getAbortHref()) {
44+
const cancelButton = progressWindow.addCancelButton();
45+
cancelButton.setLabel(qx.locale.Manager.tr("Ignore"));
46+
const abortButton = new qx.ui.form.Button().set({
47+
label: qx.locale.Manager.tr("Cancel"),
48+
center: true,
49+
minWidth: 100,
50+
});
51+
abortButton.addListener("execute", () => task.abortRequested());
52+
progressWindow.addButton(abortButton);
53+
abortButton.set({
54+
appearance: "danger-button",
55+
});
56+
}
57+
58+
task.addListener("updateReceived", e => {
59+
const data = e.getData();
60+
if (data["task_progress"]) {
61+
if ("message" in data["task_progress"] && data["task_progress"]["message"]) {
62+
progressWindow.setMessage(data["task_progress"]["message"]);
63+
}
64+
progressWindow.setProgress(osparc.data.PollTask.extractProgress(data) * 100);
65+
}
5366
});
67+
68+
task.addListener("resultReceived", () => progressWindow.close());
69+
task.addListener("taskAborted", () => progressWindow.close());
70+
task.addListener("pollingError", () => progressWindow.close());
71+
72+
progressWindow.open();
5473
}
55-
progressWindow.open();
5674

57-
task.addListener("updateReceived", e => {
58-
const data = e.getData();
59-
if (data["task_progress"]) {
60-
if ("message" in data["task_progress"] && data["task_progress"]["message"]) {
61-
progressWindow.setMessage(data["task_progress"]["message"]);
62-
}
63-
progressWindow.setProgress(osparc.data.PollTask.extractProgress(data) * 100);
64-
}
65-
});
6675
task.addListener("resultReceived", e => {
6776
const taskData = e.getData();
6877
if (taskData["result"]) {
@@ -80,16 +89,13 @@ qx.Class.define("osparc.task.ExportData", {
8089
}
8190
})
8291
}
83-
progressWindow.close();
8492
});
8593
task.addListener("taskAborted", () => {
8694
osparc.FlashMessenger.logAs(qx.locale.Manager.tr("Download aborted"), "WARNING");
87-
progressWindow.close();
8895
});
8996
task.addListener("pollingError", e => {
9097
const err = e.getData();
9198
osparc.FlashMessenger.logError(err);
92-
progressWindow.close();
9399
});
94100
}
95101
},

0 commit comments

Comments
 (0)