ok

Author: sanderegg

services/dask-sidecar/src/simcore_service_dask_sidecar/computational_sidecar/core.py

@@ -49,8 +49,8 @@
 from .task_shared_volume import TaskSharedVolumes
 
 _logger = logging.getLogger(__name__)
-CONTAINER_WAIT_TIME_SECS = 2
-MAX_LOGGED_FILE_CHARS = 40
+_CONTAINER_WAIT_TIME_SECS = 2
+_MAX_LOGGED_FILE_CHARS = 40
 
 
 @dataclass(kw_only=True, frozen=True, slots=True)
@@ -154,7 +154,10 @@ async def _retrieve_output_data(
 
                     src_path = task_volumes.outputs_folder / output_params.file_mapping
                     await log_partial_file_content(
-                        src_path, _logger, MAX_LOGGED_FILE_CHARS
+                        src_path,
+                        logger=_logger,
+                        log_level=logging.DEBUG,
+                        max_chars=_MAX_LOGGED_FILE_CHARS,
                     )
                     upload_tasks.append(
                         push_file_to_remote(
@@ -271,7 +274,7 @@ async def run(self, command: list[str]) -> TaskOutputData:
                 )
                 # wait until the container finished, either success or fail or timeout
                 while (container_data := await container.show())["State"]["Running"]:
-                    await asyncio.sleep(CONTAINER_WAIT_TIME_SECS)
+                    await asyncio.sleep(_CONTAINER_WAIT_TIME_SECS)
                 if container_data["State"]["ExitCode"] > os.EX_OK:
                     raise ServiceRuntimeError(
                         service_key=self.task_parameters.image,

services/dask-sidecar/src/simcore_service_dask_sidecar/utils/files.py

@@ -333,8 +333,13 @@ async def push_file_to_remote(
 
 
 async def log_partial_file_content(
-    src_path: Path, logger: logging.Logger, log_level: int, max_chars: int
+    src_path: Path, *, logger: logging.Logger, log_level: int, max_chars: int
 ) -> None:
+    if max_chars < 0:
+        msg = "max_chars must be non-negative"
+        raise ValueError(msg)
+    if max_chars == 0:
+        return
     if not src_path.exists():
         logger.log(log_level, "file does not exist: %s", src_path)
         return