fixes import

Author: pcrespov

docs/migration-to-web-appkey.md

@@ -0,0 +1,88 @@
+# Migration to aiohttp web.AppKey
+
+## Overview
+
+This migration updates all application keys from string-based keys to type-safe `web.AppKey` instances as recommended by aiohttp for type safety and better development experience.
+
+## Changes Made
+
+### Service Library (`packages/service-library/src/servicelib/aiohttp/`)
+
+1. **application_keys.py** - Updated with web.AppKey imports and pattern
+2. **aiopg_utils.py** - `APP_AIOPG_ENGINE_KEY`
+3. **client_session.py** - `APP_CLIENT_SESSION_KEY`
+4. **docker_utils.py** - `APP_DOCKER_ENGINE_KEY`
+5. **monitor_slow_callbacks.py** - `APP_SLOW_CALLBACKS_MONITOR_KEY`
+6. **monitoring.py** - `APP_MONITORING_NAMESPACE_KEY`
+7. **observer.py** - `APP_FIRE_AND_FORGET_TASKS_KEY`
+8. **requests_validation.py** - `APP_JSON_SCHEMA_SPECS_KEY`
+9. **rest_middlewares.py** - `APP_JSONSCHEMA_SPECS_KEY`
+10. **status.py** - `APP_HEALTH_KEY`
+11. **tracing.py** - `APP_OPENTELEMETRY_INSTRUMENTOR_KEY`
+12. **long_running_tasks/server.py** - `APP_LONG_RUNNING_TASKS_KEY`
+
+### Webserver Service (`services/web/server/src/simcore_service_webserver/`)
+
+1. **application.py** - `APP_WEBSERVER_SETTINGS_KEY`
+2. **db/plugin.py** - `APP_DB_ENGINE_KEY`
+3. **redis.py** - `APP_REDIS_CLIENT_KEY`
+4. **rabbitmq.py** - `APP_RABBITMQ_CLIENT_KEY`
+5. **catalog/plugin.py** - `APP_CATALOG_CLIENT_KEY`
+6. **director_v2/_client.py** - `APP_DIRECTOR_V2_CLIENT_KEY`
+7. **storage/plugin.py** - `APP_STORAGE_CLIENT_KEY`
+8. **socketio/plugin.py** - `APP_SOCKETIO_SERVER_KEY`
+9. **session/plugin.py** - `APP_SESSION_KEY`
+10. **projects/plugin.py** - `APP_PROJECTS_CLIENT_KEY`
+11. **users/plugin.py** - `APP_USERS_CLIENT_KEY`
+12. **login/plugin.py** - `APP_LOGIN_CLIENT_KEY`
+13. **security/plugin.py** - `APP_SECURITY_CLIENT_KEY`
+14. **resource_manager/plugin.py** - `APP_RESOURCE_MANAGER_CLIENT_KEY`
+15. **diagnostics/plugin.py** - `APP_DIAGNOSTICS_CLIENT_KEY`
+
+## Pattern Used
+
+Before:
+```python
+from typing import Final
+
+APP_MY_KEY: Final[str] = f"{__name__}.my_key"
+app[APP_MY_KEY] = value
+data = request.app[APP_MY_KEY]
+```
+
+After:
+```python
+from typing import Final
+from aiohttp import web
+
+APP_MY_KEY: Final = web.AppKey("APP_MY_KEY", SomeSpecificType)
+app[APP_MY_KEY] = value
+data = request.app[APP_MY_KEY]  # Now type-safe with proper type
+```
+
+## Type Improvements
+
+Where possible, we've used specific types instead of generic `object`:
+
+- `APP_AIOPG_ENGINE_KEY` uses `Engine` (from aiopg)
+- `APP_CLIENT_SESSION_KEY` uses `aiohttp.ClientSession`
+- `APP_DOCKER_ENGINE_KEY` uses `aiodocker.Docker`
+- `APP_REDIS_CLIENT_KEY` uses `RedisClientsManager`
+- `APP_CONFIG_KEY` uses `dict[str, object]`
+- `APP_JSON_SCHEMA_SPECS_KEY` uses `dict[str, object]`
+- `APP_FIRE_AND_FORGET_TASKS_KEY` uses `set[object]`
+- `APP_SLOW_CALLBACKS_MONITOR_KEY` uses `LimitedOrderedStack[SlowCallback]`
+
+## Benefits
+
+1. **Type Safety**: mypy can now properly type-check app key access with specific types
+2. **Better IDE Support**: IDEs can provide better autocomplete and error detection
+3. **Runtime Safety**: aiohttp validates key types at runtime
+4. **Documentation**: Key types are self-documenting and more precise
+
+## Next Steps
+
+- Update unit tests to use the new AppKey patterns
+- Update any remaining string-based app key usage
+- Consider consolidating common keys in shared modules for frequently used keys across multiple plugins
+- Continue refining types from `object` to more specific types where the actual type is known

services/web/server/src/simcore_service_webserver/constants.py

@@ -17,10 +17,11 @@
     # Application settings key - defined here to avoid circular imports
     from .application_settings import ApplicationSettings
 
-
-APP_SETTINGS_KEY: web.AppKey[ApplicationSettings] = web.AppKey(
-    "APP_SETTINGS_KEY", "ApplicationSettings"  # Use string to avoid import
-)
+    APP_SETTINGS_KEY: web.AppKey[ApplicationSettings] = web.AppKey(
+        "APP_SETTINGS_KEY", ApplicationSettings
+    )
+else:
+    APP_SETTINGS_KEY: web.AppKey = web.AppKey("APP_SETTINGS_KEY", None)
 
 
 # Application storage keys