Skip to content

Commit d60a753

Browse files
committed
remove comments
1 parent 619cabf commit d60a753

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

services/autoscaling/src/simcore_service_autoscaling/modules/cluster_scaling/_provider_computational.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,7 @@ async def list_unrunnable_tasks(self, app: FastAPI) -> list[DaskTask]:
8888

8989
def get_task_required_resources(self, task) -> Resources:
9090
assert self # nosec
91-
# NOTE: a dask worker can take a task if it has a free thread, regardless of its resources
92-
# so we need to be careful when interpreting the resources, adding the thread here will mimick this
93-
task_required_resources = utils.resources_from_dask_task(task)
94-
# TODO: should we add a generic resource for threads?
95-
# task_required_resources.generic_resources[_DASK_WORKER_THREAD_RESOURCE_NAME] = 1
96-
return task_required_resources
91+
return utils.resources_from_dask_task(task)
9792

9893
async def get_task_defined_instance(
9994
self, app: FastAPI, task

0 commit comments

Comments
 (0)