model shall not silently do stuff

Author: sanderegg

packages/models-library/src/models_library/projects_state.py

@@ -146,11 +146,17 @@ def _update_json_schema_extra(schema: JsonDict) -> None:
 
     @model_validator(mode="after")
     def check_model_valid(self) -> Self:
-        self.locked = self.status in [
-            ProjectStatus.CLONING,
-            ProjectStatus.EXPORTING,
-            ProjectStatus.MAINTAINING,
-        ]
+        if (
+            self.status
+            in [
+                ProjectStatus.CLONING,
+                ProjectStatus.EXPORTING,
+                ProjectStatus.MAINTAINING,
+            ]
+            and not self.locked
+        ):
+            msg = f"Project is {self.status=}, but it is not locked"
+            raise ValueError(msg)
         if self.locked and not self.current_user_groupids:
             msg = "If the project is locked, the current_users list must contain at least the lock owner"
             raise ValueError(msg)

services/web/server/src/simcore_service_webserver/projects/_projects_service.py

@@ -1601,7 +1601,7 @@ async def _get_project_share_state(
 
     return ProjectShareState(
         status=ProjectStatus.OPENED,
-        locked=app_settings.WEBSERVER_REALTIME_COLLABORATION is None,
+        locked=bool(app_settings.WEBSERVER_REALTIME_COLLABORATION is None),
         current_user_groupids=await limited_gather(
             *[
                 users_service.get_user_primary_group_id(app, user_id=uid)