Skip to content

Commit d90de58

Browse files
authored
RRID classifiers UX (#2060)
FORCED EMERGENCY MERGE! * rename * fix * listen to classifiers change * DO NOT check progress value but if "progress" exists
1 parent f72ba62 commit d90de58

File tree

6 files changed

+20
-13
lines changed

6 files changed

+20
-13
lines changed

services/web/client/source/class/osparc/component/filter/ClassifiersFilter.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ qx.Class.define("osparc.component.filter.ClassifiersFilter", {
2121
members: {
2222
__tree: null,
2323

24-
reloadTree: function(reload = true) {
24+
recreateTree: function() {
2525
const checkedClassifiers = this.getCheckedClassifierIDs();
26-
this.__createClassifiersTree(checkedClassifiers, reload);
26+
this.__createClassifiersTree(checkedClassifiers);
2727
},
2828

29-
__createClassifiersTree: function(checkedClassifiers, reload) {
30-
osparc.utils.Classifiers.getClassifiersAsTree(reload = false)
29+
__createClassifiersTree: function(checkedClassifiers, reload = false) {
30+
osparc.utils.Classifiers.getClassifiersAsTree(reload)
3131
.then(classifiers => {
3232
if (classifiers && classifiers.children.length) {
3333
this.__tree = new osparc.ui.tree.CheckboxTree(classifiers);

services/web/client/source/class/osparc/dashboard/ClassifiersEditor.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ qx.Class.define("osparc.dashboard.ClassifiersEditor", {
6666
flex: 1
6767
});
6868

69-
const addRRIDClassfierBtn = new osparc.ui.form.FetchButton(this.tr("Add RRID Classifier"));
69+
const addRRIDClassfierBtn = new osparc.ui.form.FetchButton(this.tr("Add Classifier"));
7070
addRRIDClassfierBtn.addListener("execute", () => {
7171
this.__addRRIDClassfier(textField.getValue(), addRRIDClassfierBtn);
7272
}, this);
@@ -79,6 +79,9 @@ qx.Class.define("osparc.dashboard.ClassifiersEditor", {
7979
const studyData = this.__studyData;
8080
const classifiers = studyData.classifiers && studyData.classifiers ? studyData.classifiers : [];
8181
const classifiersTree = this.__classifiersTree = new osparc.component.filter.ClassifiersFilter("classifiersEditor", "sideSearchFilter", classifiers);
82+
osparc.store.Store.getInstance().addListener("changeClassifiers", e => {
83+
classifiersTree.recreateTree();
84+
}, this);
8285
this._add(classifiersTree, {
8386
flex: 1
8487
});
@@ -106,7 +109,7 @@ qx.Class.define("osparc.dashboard.ClassifiersEditor", {
106109
osparc.data.Resources.fetch("classifiers", "postRRID", params)
107110
.then(() => {
108111
osparc.component.message.FlashMessenger.getInstance().logAs(this.tr("RRID classifier successfuly added"), "INFO");
109-
this.__classifiersTree.reloadTree();
112+
osparc.store.Store.getInstance().getAllClassifiers(true);
110113
})
111114
.catch(err => {
112115
osparc.component.message.FlashMessenger.getInstance().logAs(this.tr("Invalid RRID"), "ERROR");

services/web/client/source/class/osparc/dashboard/SideSearch.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ qx.Class.define("osparc.dashboard.SideSearch", {
5959
marginLeft: -12,
6060
marginTop: -5
6161
});
62+
osparc.store.Store.getInstance().addListener("changeClassifiers", e => {
63+
classifier.recreateTree();
64+
}, this);
6265
this._add(classifier, {
6366
flex: 1
6467
});

services/web/client/source/class/osparc/data/model/Node.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ qx.Class.define("osparc.data.model.Node", {
342342
this.getStatus().setRunningStatus(nodeData.state);
343343
}
344344

345-
if (nodeData.progress) {
345+
if ("progress" in nodeData) {
346346
this.getStatus().setProgress(nodeData.progress);
347347
}
348348

services/web/client/source/class/osparc/desktop/WorkbenchView.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -670,11 +670,11 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
670670
const node = workbench.getNode(nodeId);
671671
if (node && nodeData) {
672672
node.setOutputData(nodeData.outputs);
673-
if (nodeData.progress) {
674-
const progress = Number.parseInt(nodeData.progress);
675-
if ("state" in nodeData && node.isComputational()) {
676-
node.getStatus().setRunningStatus(nodeData["state"]);
677-
}
673+
if ("state" in nodeData && node.isComputational()) {
674+
node.getStatus().setRunningStatus(nodeData["state"]);
675+
}
676+
if ("progress" in nodeData) {
677+
const progress = Number.parseInt(nodeData["progress"]);
678678
node.getStatus().setProgress(progress);
679679
}
680680
} else if (osparc.data.Permissions.getInstance().isTester()) {

services/web/client/source/class/osparc/store/Store.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,8 @@ qx.Class.define("osparc.store.Store", {
117117
},
118118
classifiers: {
119119
check: "Array",
120-
init: []
120+
init: [],
121+
event: "changeClassifiers"
121122
}
122123
},
123124

0 commit comments

Comments
 (0)