Skip to content

Commit da4edf4

Browse files
author
Andrei Neagu
committed
repalced with inmemory redis
1 parent b44d641 commit da4edf4

File tree

7 files changed

+20
-26
lines changed

7 files changed

+20
-26
lines changed
Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,9 @@
1-
# pylint: disable=unused-argument
2-
3-
import functools
4-
51
import pytest
2+
from fakeredis import FakeAsyncRedis
63
from pytest_mock import MockerFixture
7-
from servicelib.long_running_tasks import task
8-
from servicelib.long_running_tasks._store.in_memory import InMemoryStore
9-
10-
11-
def _mock_decorator_with_args(*decorator_args, **decorator_kwargs):
12-
def decorator(func):
13-
@functools.wraps(func)
14-
async def wrapper(*func_args, **func_kwargs):
15-
return await func(*func_args, **func_kwargs)
16-
17-
return wrapper
18-
19-
return decorator
4+
from servicelib.redis import _client
205

216

227
@pytest.fixture
23-
def use_in_memory_long_running_tasks(mocker: MockerFixture) -> None:
24-
mocker.patch.object(task, "RedisStore", InMemoryStore)
25-
# for testing the exclsive is not required so it's disabled
26-
mocker.patch.object(task, "exclusive", _mock_decorator_with_args)
8+
async def use_in_memory_redis(mocker: MockerFixture) -> None:
9+
mocker.patch.object(_client, "aioredis", FakeAsyncRedis)

services/director-v2/requirements/_test.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ async-asgi-testclient # replacement for fastapi.testclient.TestClient [see b) be
1717
dask[distributed,diagnostics]
1818
docker
1919
Faker
20+
fakeredis[lua]
2021
flaky
2122
pytest
2223
pytest-asyncio

services/director-v2/requirements/_test.txt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,8 @@ execnet==2.1.1
9999
# via pytest-xdist
100100
faker==37.3.0
101101
# via -r requirements/_test.in
102+
fakeredis==2.30.3
103+
# via -r requirements/_test.in
102104
flaky==3.8.1
103105
# via -r requirements/_test.in
104106
frozenlist==1.6.0
@@ -159,6 +161,8 @@ locket==1.0.0
159161
# -c requirements/_base.txt
160162
# distributed
161163
# partd
164+
lupa==2.5
165+
# via fakeredis
162166
mako==1.3.10
163167
# via
164168
# -c requirements/../../../requirements/constraints.txt
@@ -271,6 +275,11 @@ pyyaml==6.0.2
271275
# bokeh
272276
# dask
273277
# distributed
278+
redis==6.1.0
279+
# via
280+
# -c requirements/../../../requirements/constraints.txt
281+
# -c requirements/_base.txt
282+
# fakeredis
274283
requests==2.32.4
275284
# via
276285
# -c requirements/_base.txt
@@ -293,6 +302,7 @@ sortedcontainers==2.4.0
293302
# via
294303
# -c requirements/_base.txt
295304
# distributed
305+
# fakeredis
296306
sqlalchemy==1.4.54
297307
# via
298308
# -c requirements/../../../requirements/constraints.txt

services/director-v2/tests/unit/test_api_route_dynamic_scheduler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
@pytest.fixture
2929
def mock_env(
30-
use_in_memory_long_running_tasks: None,
30+
use_in_memory_redis: None,
3131
mock_exclusive: None,
3232
disable_rabbitmq: None,
3333
disable_postgres: None,

services/director-v2/tests/unit/test_modules_dynamic_sidecar_scheduler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ async def _assert_get_dynamic_services_mocked(
124124

125125
@pytest.fixture
126126
def mock_env(
127-
use_in_memory_long_running_tasks: None,
127+
use_in_memory_redis: None,
128128
mock_exclusive: None,
129129
disable_postgres: None,
130130
disable_rabbitmq: None,

services/director-v2/tests/unit/test_modules_dynamic_sidecar_scheduler_task.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343

4444
@pytest.fixture
4545
def mock_env(
46-
use_in_memory_long_running_tasks: None,
46+
use_in_memory_redis: None,
4747
disable_postgres: None,
4848
disable_rabbitmq: None,
4949
mock_env: EnvVarsDict,

services/dynamic-sidecar/tests/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def mock_rabbit_check(mocker: MockerFixture) -> None:
169169

170170
@pytest.fixture
171171
def base_mock_envs(
172-
use_in_memory_long_running_tasks: None,
172+
use_in_memory_redis: None,
173173
dy_volumes: Path,
174174
shared_store_dir: Path,
175175
compose_namespace: str,
@@ -211,7 +211,7 @@ def base_mock_envs(
211211

212212
@pytest.fixture
213213
def mock_environment(
214-
use_in_memory_long_running_tasks: None,
214+
use_in_memory_redis: None,
215215
mock_storage_check: None,
216216
mock_postgres_check: None,
217217
mock_rabbit_check: None,

0 commit comments

Comments
 (0)