Skip to content

Commit da58d27

Browse files
committed
f=tests
1 parent f3d4d43 commit da58d27

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

packages/pytest-simcore/src/pytest_simcore/helpers/faker_factories.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,11 @@ def random_thumbnail_url(fake: Faker):
3333
return fake.image_url(width=32, height=32)
3434

3535

36-
def random_phone_number(fake: Faker) -> str:
36+
def random_phone_number(fake: Faker = DEFAULT_FAKER) -> str:
3737
# NOTE: faker.phone_number() does not validate with `phonenumbers` library.
38-
phone = fake.random_element(["+41763456789", "+19104630364", "+13013044567"])
38+
phone = fake.random_element(
39+
["+41763456789", "+19104630364", "+13013044567", "+34 951 453 837"]
40+
)
3941
tail = f"{fake.pyint(100, 999)}"
4042
return phone[: -len(tail)] + tail # ensure phone keeps its length
4143

services/web/server/tests/unit/isolated/test_models.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,17 @@
1212
PhoneNumberStr,
1313
)
1414

15+
from services.web.server.tests.conftest import random_phone_number
16+
1517

1618
@pytest.mark.parametrize(
1719
"phone",
18-
["+41763456789", "+19104630364", "+1 301-304-4567"],
20+
["+41763456789", "+19104630364", "+1 301-304-4567"]
21+
+ [
22+
# tests hand-made random_phone_number
23+
random_phone_number()
24+
for _ in range(6)
25+
],
1926
)
2027
def test_valid_phone_numbers(phone: str):
2128
# This test is used to tune options of PhoneNumberValidator

0 commit comments

Comments
 (0)