Skip to content

Commit da917ac

Browse files
committed
refactor
1 parent 570c2f2 commit da917ac

File tree

2 files changed

+29
-24
lines changed

2 files changed

+29
-24
lines changed

services/static-webserver/client/source/class/osparc/data/model/Conversation.js

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ qx.Class.define("osparc.data.model.Conversation", {
121121

122122
members: {
123123
__fetchLastMessagePromise: null,
124+
__nextRequestParams: null,
124125

125126
__applyName: function(name) {
126127
if (name && name !== "null") {
@@ -161,6 +162,32 @@ qx.Class.define("osparc.data.model.Conversation", {
161162
return this.__fetchLastMessage();
162163
},
163164

165+
getNextMessages: function() {
166+
const params = {
167+
url: {
168+
conversationId: this.getConversationId(),
169+
offset: 0,
170+
limit: 42
171+
}
172+
};
173+
const nextRequestParams = this.__nextRequestParams;
174+
if (nextRequestParams) {
175+
params.url.offset = nextRequestParams.offset;
176+
params.url.limit = nextRequestParams.limit;
177+
}
178+
const options = {
179+
resolveWResponse: true
180+
};
181+
return osparc.data.Resources.fetch("conversationsSupport", "getMessagesPage", params, options)
182+
.then(resp => {
183+
const messages = resp["data"];
184+
messages.forEach(message => this.addMessage(message));
185+
this.__nextRequestParams = resp["_links"]["next"];
186+
return resp;
187+
})
188+
.catch(err => osparc.FlashMessenger.logError(err));
189+
},
190+
164191
renameConversation: function(newName) {
165192
osparc.store.ConversationsSupport.getInstance().renameConversation(this.getConversationId(), newName)
166193
.then(() => {

services/static-webserver/client/source/class/osparc/support/Conversation.js

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ qx.Class.define("osparc.support.Conversation", {
5656

5757
members: {
5858
__messages: null,
59-
__nextRequestParams: null,
6059

6160
_createChildControlImpl: function(id) {
6261
let control;
@@ -138,26 +137,6 @@ qx.Class.define("osparc.support.Conversation", {
138137
}
139138
},
140139

141-
__getNextRequest: function() {
142-
const params = {
143-
url: {
144-
conversationId: this.getConversation().getConversationId(),
145-
offset: 0,
146-
limit: 42
147-
}
148-
};
149-
const nextRequestParams = this.__nextRequestParams;
150-
if (nextRequestParams) {
151-
params.url.offset = nextRequestParams.offset;
152-
params.url.limit = nextRequestParams.limit;
153-
}
154-
const options = {
155-
resolveWResponse: true
156-
};
157-
return osparc.data.Resources.fetch("conversationsSupport", "getMessagesPage", params, options)
158-
.catch(err => osparc.FlashMessenger.logError(err));
159-
},
160-
161140
__reloadMessages: function(removeMessages = true) {
162141
const messagesContainer = this.getChildControl("messages-container");
163142
const loadMoreMessages = this.getChildControl("load-more-button");
@@ -176,12 +155,11 @@ qx.Class.define("osparc.support.Conversation", {
176155
messagesContainer.removeAll();
177156
}
178157

179-
this.__getNextRequest()
158+
this.getConversation().getNextMessages()
180159
.then(resp => {
181160
const messages = resp["data"];
182161
messages.forEach(message => this.addMessage(message));
183-
this.__nextRequestParams = resp["_links"]["next"];
184-
if (this.__nextRequestParams === null && loadMoreMessages) {
162+
if (resp["_links"]["next"] === null && loadMoreMessages) {
185163
loadMoreMessages.exclude();
186164
}
187165
})

0 commit comments

Comments
 (0)