Skip to content

Commit dbc7f68

Browse files
committed
refactor
1 parent a226254 commit dbc7f68

File tree

3 files changed

+53
-50
lines changed

3 files changed

+53
-50
lines changed

services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -482,6 +482,54 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
482482
}
483483
},
484484

485+
taskToTemplateReceived: function(task, studyName, templateType) {
486+
const toTemplateTaskUI = new osparc.task.ToTemplate(studyName);
487+
toTemplateTaskUI.setTask(task);
488+
489+
osparc.task.TasksContainer.getInstance().addTaskUI(toTemplateTaskUI);
490+
491+
const cardTitle = this.tr("Publishing ") + studyName;
492+
const toTemplateCard = this._addTaskCard(task, cardTitle, osparc.task.ToTemplate.ICON);
493+
if (toTemplateCard) {
494+
this.__attachToTemplateEventHandler(task, toTemplateCard, templateType);
495+
}
496+
},
497+
498+
__attachToTemplateEventHandler: function(task, toTemplateCard, templateType) {
499+
const finished = () => {
500+
this._resourcesContainer.removeNonResourceCard(toTemplateCard);
501+
};
502+
503+
task.addListener("updateReceived", e => {
504+
const updateData = e.getData();
505+
if ("task_progress" in updateData && toTemplateCard) {
506+
const taskProgress = updateData["task_progress"];
507+
toTemplateCard.getChildControl("progress-bar").set({
508+
value: osparc.data.PollTask.extractProgress(updateData) * 100
509+
});
510+
toTemplateCard.getChildControl("state-label").set({
511+
value: taskProgress["message"]
512+
});
513+
}
514+
}, this);
515+
task.addListener("resultReceived", e => {
516+
finished();
517+
this.reloadResources();
518+
const msg = templateType + this.tr(" created");
519+
osparc.FlashMessenger.logAs(msg, "INFO");
520+
});
521+
task.addListener("taskAborted", () => {
522+
finished();
523+
const msg = this.tr("Study to Template cancelled");
524+
osparc.FlashMessenger.logAs(msg, "WARNING");
525+
});
526+
task.addListener("pollingError", e => {
527+
finished();
528+
const err = e.getData();
529+
osparc.FlashMessenger.logError(err);
530+
});
531+
},
532+
485533
_addTaskCard: function(task, cardTitle, cardIcon) {
486534
if (!this._resourcesContainer) {
487535
return null;

services/static-webserver/client/source/class/osparc/dashboard/TutorialBrowser.js

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -355,54 +355,6 @@ qx.Class.define("osparc.dashboard.TutorialBrowser", {
355355
this.taskToTemplateReceived(task, studyName);
356356
});
357357
},
358-
359-
taskToTemplateReceived: function(task, studyName) {
360-
const toTemplateTaskUI = new osparc.task.ToTemplate(studyName);
361-
toTemplateTaskUI.setTask(task);
362-
363-
osparc.task.TasksContainer.getInstance().addTaskUI(toTemplateTaskUI);
364-
365-
const cardTitle = this.tr("Publishing ") + studyName;
366-
const toTemplateCard = this._addTaskCard(task, cardTitle, osparc.task.ToTemplate.ICON);
367-
if (toTemplateCard) {
368-
this.__attachToTemplateEventHandler(task, toTemplateCard);
369-
}
370-
},
371-
372-
__attachToTemplateEventHandler: function(task, toTemplateCard) {
373-
const finished = () => {
374-
this._resourcesContainer.removeNonResourceCard(toTemplateCard);
375-
};
376-
377-
task.addListener("updateReceived", e => {
378-
const updateData = e.getData();
379-
if ("task_progress" in updateData && toTemplateCard) {
380-
const taskProgress = updateData["task_progress"];
381-
toTemplateCard.getChildControl("progress-bar").set({
382-
value: osparc.data.PollTask.extractProgress(updateData) * 100
383-
});
384-
toTemplateCard.getChildControl("state-label").set({
385-
value: taskProgress["message"]
386-
});
387-
}
388-
}, this);
389-
task.addListener("resultReceived", e => {
390-
finished();
391-
this.reloadResources();
392-
const msg = this.tr("Tutorial created");
393-
osparc.FlashMessenger.logAs(msg, "INFO");
394-
});
395-
task.addListener("taskAborted", () => {
396-
finished();
397-
const msg = this.tr("Study to Tutorial cancelled");
398-
osparc.FlashMessenger.logAs(msg, "WARNING");
399-
});
400-
task.addListener("pollingError", e => {
401-
finished();
402-
const err = e.getData();
403-
osparc.FlashMessenger.logError(err);
404-
});
405-
},
406358
// TASKS //
407359
}
408360
});

services/static-webserver/client/source/class/osparc/desktop/MainPage.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,9 +249,12 @@ qx.Class.define("osparc.desktop.MainPage", {
249249
pollTasks.createPollingTask(fetchPromise)
250250
.then(task => {
251251
const tutorialBrowser = this.__dashboard.getTutorialBrowser();
252+
if (tutorialBrowser && templateType === osparc.data.model.StudyUI.TUTORIAL_TYPE) {
253+
tutorialBrowser.taskToTemplateReceived(task, studyName, templateType);
254+
}
252255
const appBrowser = this.__dashboard.getAppBrowser();
253-
if (tutorialBrowser) {
254-
tutorialBrowser.taskToTemplateReceived(task, studyName);
256+
if (appBrowser && templateType === osparc.data.model.StudyUI.HYPERTOOL_TYPE) {
257+
appBrowser.taskToTemplateReceived(task, studyName, templateType);
255258
}
256259
task.addListener("resultReceived", e => {
257260
const templateData = e.getData();

0 commit comments

Comments
 (0)