🐛 Refactor error handling to use safe_status_message for HTTP reason attributes in exception responses

Author: pcrespov

services/web/server/src/simcore_service_webserver/exception_handling/_factory.py

@@ -5,6 +5,7 @@
 from common_library.error_codes import create_error_code
 from common_library.json_serialization import json_dumps
 from models_library.rest_error import ErrorGet
+from servicelib.aiohttp.rest_responses import safe_status_message
 from servicelib.aiohttp.web_exceptions_extension import get_all_aiohttp_http_exceptions
 from servicelib.logging_errors import create_troubleshotting_log_kwargs
 from servicelib.status_codes_utils import is_5xx_server_error, is_error
@@ -40,8 +41,7 @@ def create_error_response(error: ErrorGet, status_code: int) -> web.Response:
     return web.json_response(
         data={"error": error.model_dump(exclude_unset=True, mode="json")},
         dumps=json_dumps,
-        # NOTE: Multiline not allowed in HTTP reason attribute (aiohttp now raises ValueError)
-        reason=error.message.replace("\n", " ") if error.message else None,
+        reason=safe_status_message(error.message),
         status=status_code,
     )
 

services/web/server/src/simcore_service_webserver/exporter/exceptions.py

@@ -1,10 +1,10 @@
 from aiohttp.web import HTTPBadRequest
+from servicelib.aiohttp.rest_responses import safe_status_message
 
 
 class SDSException(HTTPBadRequest):  # pylint: disable=too-many-ancestors
     # NOTE: all these errors will displayed to the user
     """Basic exception for errors raised inside the module"""
 
     def __init__(self, message: str):
-        # Multiline not allowed in HTTP reason attribute
-        super().__init__(reason=message.replace("\n", " ") if message else None)
+        super().__init__(reason=safe_status_message(message))

services/web/server/src/simcore_service_webserver/exporter/utils.py

@@ -6,6 +6,7 @@
 from aiohttp.abc import AbstractStreamWriter
 from aiohttp.typedefs import LooseHeaders
 from aiohttp.web import BaseRequest, FileResponse
+from servicelib.aiohttp.rest_responses import safe_status_message
 
 
 class CleanupFileResponse(FileResponse):  # pylint: disable=too-many-ancestors
@@ -27,8 +28,7 @@ def __init__(
             path=path,
             chunk_size=chunk_size,
             status=status,
-            # Multiline not allowed in HTTP reason
-            reason=reason.replace("\n", " ") if reason else None,
+            reason=safe_status_message(reason),
             headers=headers,
         )
         self.remove_tmp_dir_cb = remove_tmp_dir_cb