Skip to content

Commit dd18d34

Browse files
GitHKAndrei Neagu
andauthored
🎨 backend pulls inputs before iframe is displayed (#6392)
Co-authored-by: Andrei Neagu <[email protected]>
1 parent f58cebc commit dd18d34

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_user_services.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,9 @@ async def progress_create_containers(
223223

224224
scheduler_data.dynamic_sidecar.were_containers_created = True
225225

226+
# NOTE: user services are already in running state, meaning it is safe to pull inputs
227+
await sidecars_client.pull_service_input_ports(dynamic_sidecar_endpoint)
228+
226229
start_duration = (
227230
scheduler_data.dynamic_sidecar.instrumentation.elapsed_since_start_request()
228231
)

services/static-webserver/client/source/class/osparc/data/model/IframeHandler.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,9 @@ qx.Class.define("osparc.data.model.IframeHandler", {
364364
};
365365
node.fireDataEvent("showInLogger", msgData);
366366
this.__restartIFrame();
367-
node.callRetrieveInputs();
367+
if (!node.isDynamicV2()) {
368+
node.callRetrieveInputs();
369+
}
368370
},
369371

370372
__restartIFrame: function() {

0 commit comments

Comments
 (0)