Skip to content

Commit ddb62a5

Browse files
committed
Fix pytest
1 parent 4f8c061 commit ddb62a5

File tree

1 file changed

+8
-38
lines changed

1 file changed

+8
-38
lines changed

packages/service-library/tests/fastapi/test_tracing.py

Lines changed: 8 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# pylint: disable=all
22

33

4+
import random
5+
import string
46
from collections.abc import Callable
57
from typing import Any
68

@@ -69,7 +71,12 @@ async def test_valid_tracing_settings(
6971
("http://opentelemetry-collector", 1238712936),
7072
("opentelemetry-collector", 4318),
7173
("httsdasp://ot@##el-collector", 4318),
72-
(None, "1238712936"),
74+
(" !@#$%^&*()[]{};:,<>?\\|`~+=/'\"", 4318),
75+
# The following exceeds max DNS name length
76+
(
77+
"".join(random.choice(string.ascii_letters) for _ in range(300)),
78+
"1238712936",
79+
), # noqa: S311
7380
],
7481
indirect=True,
7582
)
@@ -86,40 +93,3 @@ async def test_invalid_tracing_settings(
8693
tracing_settings=tracing_settings,
8794
service_name="Mock-Openetlemetry-Pytest",
8895
)
89-
90-
91-
@pytest.mark.parametrize(
92-
"tracing_settings_in", # noqa: PT002
93-
[("", ""), ("", None), (None, None)],
94-
indirect=True,
95-
)
96-
async def test_missing_tracing_settings(
97-
mocked_app: FastAPI,
98-
set_and_clean_settings_env_vars: Callable[[], None],
99-
tracing_settings_in: Callable[[], dict[str, Any]],
100-
):
101-
tracing_settings = TracingSettings()
102-
setup_tracing(
103-
mocked_app,
104-
tracing_settings=tracing_settings,
105-
service_name="Mock-Openetlemetry-Pytest",
106-
)
107-
108-
109-
@pytest.mark.parametrize(
110-
"tracing_settings_in",
111-
[("http://opentelemetry-collector", None), (None, 4318)],
112-
indirect=True,
113-
)
114-
async def test_incomplete_tracing_settings(
115-
set_and_clean_settings_env_vars: Callable[[], None],
116-
tracing_settings_in: Callable[[], dict[str, Any]],
117-
mocked_app: FastAPI,
118-
):
119-
tracing_settings = TracingSettings()
120-
with pytest.raises(RuntimeError):
121-
setup_tracing(
122-
mocked_app,
123-
tracing_settings=tracing_settings,
124-
service_name="Mock-Openetlemetry-Pytest",
125-
)

0 commit comments

Comments
 (0)