adding test for open project

Author: matusdrobuliak66

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/resource_usage_tracker/service_runs.py

@@ -1,3 +1,4 @@
+# pylint: disable=too-many-arguments
 import logging
 from typing import Final
 

services/web/server/src/simcore_service_webserver/projects/_nodes_handlers.py

@@ -80,13 +80,13 @@
     ClustersKeeperNotAvailableError,
     DefaultPricingUnitNotFoundError,
     NodeNotFoundError,
+    ProjectInDebtCanNotChangeWalletError,
     ProjectInvalidRightsError,
     ProjectNodeRequiredInputsNotSetError,
     ProjectNodeResourcesInsufficientRightsError,
     ProjectNodeResourcesInvalidError,
     ProjectNotFoundError,
     ProjectStartsTooManyDynamicNodesError,
-    ProjectWalletDebtError,
 )
 
 _logger = logging.getLogger(__name__)
@@ -108,7 +108,10 @@ async def wrapper(request: web.Request) -> web.StreamResponse:
             CatalogItemNotFoundError,
         ) as exc:
             raise web.HTTPNotFound(reason=f"{exc}") from exc
-        except (WalletNotEnoughCreditsError, ProjectWalletDebtError) as exc:
+        except (
+            WalletNotEnoughCreditsError,
+            ProjectInDebtCanNotChangeWalletError,
+        ) as exc:
             raise web.HTTPPaymentRequired(reason=f"{exc}") from exc
         except ProjectInvalidRightsError as exc:
             raise web.HTTPUnauthorized(reason=f"{exc}") from exc

services/web/server/src/simcore_service_webserver/projects/_states_handlers.py

@@ -41,11 +41,12 @@
 from ._common.models import ProjectPathParams, RequestContext
 from .exceptions import (
     DefaultPricingUnitNotFoundError,
+    ProjectInDebtCanNotChangeWalletError,
+    ProjectInDebtCanNotOpenError,
     ProjectInvalidRightsError,
     ProjectNotFoundError,
     ProjectStartsTooManyDynamicNodesError,
     ProjectTooManyProjectOpenedError,
-    ProjectWalletDebtError,
 )
 
 _logger = logging.getLogger(__name__)
@@ -76,7 +77,11 @@ async def _wrapper(request: web.Request) -> web.StreamResponse:
         except ProjectTooManyProjectOpenedError as exc:
             raise web.HTTPConflict(reason=f"{exc}") from exc
 
-        except (WalletNotEnoughCreditsError, ProjectWalletDebtError) as exc:
+        except (
+            WalletNotEnoughCreditsError,
+            ProjectInDebtCanNotChangeWalletError,
+            ProjectInDebtCanNotOpenError,
+        ) as exc:
             raise web.HTTPPaymentRequired(reason=f"{exc}") from exc
 
     return _wrapper

services/web/server/src/simcore_service_webserver/projects/_wallets_api.py

@@ -14,15 +14,16 @@
     credit_transactions,
     service_runs,
 )
-from simcore_service_webserver.projects.exceptions import (
-    ProjectWalletDebtError,
-    ProjectWalletPendingTransactionError,
-)
 
 from ..rabbitmq import get_rabbitmq_rpc_client
 from ..users import api as users_api
 from ..wallets import _api as wallets_api
 from .db import ProjectDBAPI
+from .exceptions import (
+    ProjectInDebtCanNotChangeWalletError,
+    ProjectInDebtCanNotOpenError,
+    ProjectWalletPendingTransactionError,
+)
 
 
 async def get_project_wallet(app, project_id: ProjectID):
@@ -44,7 +45,7 @@ async def raise_if_project_is_in_debt(
     rpc_client = get_rabbitmq_rpc_client(app)
 
     if current_project_wallet:
-        # Do not allow to change wallet if the project connected wallet is in DEBT!
+        # Do not allow to open project if the project connected wallet is in DEBT!
         project_wallet_credits_in_debt = (
             await credit_transactions.get_project_wallet_total_credits(
                 rpc_client,
@@ -55,7 +56,7 @@ async def raise_if_project_is_in_debt(
             )
         )
         if project_wallet_credits_in_debt.available_osparc_credits < 0:
-            raise ProjectWalletDebtError(
+            raise ProjectInDebtCanNotOpenError(
                 debt_amount=project_wallet_credits_in_debt.available_osparc_credits
             )
 
@@ -93,7 +94,7 @@ async def connect_wallet_to_project(
             )
         )
         if project_wallet_credits_in_debt.available_osparc_credits < 0:
-            raise ProjectWalletDebtError(
+            raise ProjectInDebtCanNotChangeWalletError(
                 debt_amount=project_wallet_credits_in_debt.available_osparc_credits
             )
 

services/web/server/src/simcore_service_webserver/projects/_wallets_handlers.py

@@ -28,9 +28,9 @@
 from . import projects_api
 from ._common.models import ProjectPathParams, RequestContext
 from .exceptions import (
+    ProjectInDebtCanNotChangeWalletError,
     ProjectInvalidRightsError,
     ProjectNotFoundError,
-    ProjectWalletDebtError,
     ProjectWalletPendingTransactionError,
 )
 
@@ -49,7 +49,7 @@ async def wrapper(request: web.Request) -> web.StreamResponse:
         except WalletNotFoundError as exc:
             raise web.HTTPNotFound(reason=f"{exc}") from exc
 
-        except ProjectWalletDebtError as exc:
+        except ProjectInDebtCanNotChangeWalletError as exc:
             raise web.HTTPPaymentRequired(reason=f"{exc}") from exc
 
         except (

services/web/server/src/simcore_service_webserver/projects/exceptions.py

@@ -238,10 +238,12 @@ class ProjectGroupNotFoundError(BaseProjectError):
     msg_template = "Project group not found. {reason}"
 
 
-class ProjectWalletDebtError(BaseProjectError):
-    msg_template = (
-        "Project is in debt {debt_amount} credits. It is forbidden to change wallet."
-    )
+class ProjectInDebtCanNotChangeWalletError(BaseProjectError):
+    msg_template = "Can not change wallet on a project that is in debt. Project debt {debt_amount} credits. Project wallet {wallet_id}"
+
+
+class ProjectInDebtCanNotOpenError(BaseProjectError):
+    msg_template = "Can not open project that is in debt. Project debt {debt_amount} credits. Project wallet {wallet_id}"
 
 
 class ProjectWalletPendingTransactionError(BaseProjectError):

services/web/server/tests/unit/with_dbs/02/test_projects_states_handlers.py

@@ -10,6 +10,7 @@
 from collections.abc import Awaitable, Callable, Iterator
 from copy import deepcopy
 from datetime import UTC, datetime, timedelta
+from decimal import Decimal
 from http import HTTPStatus
 from typing import Any
 from unittest import mock
@@ -26,6 +27,9 @@
     DynamicServiceStart,
     DynamicServiceStop,
 )
+from models_library.api_schemas_resource_usage_tracker.credit_transactions import (
+    WalletTotalCredits,
+)
 from models_library.api_schemas_webserver.projects_nodes import NodeGet, NodeGetIdle
 from models_library.projects import ProjectID
 from models_library.projects_access import Owner
@@ -43,6 +47,7 @@
 )
 from models_library.utils.fastapi_encoders import jsonable_encoder
 from pydantic import PositiveInt
+from pytest_mock import MockerFixture
 from pytest_simcore.helpers.assert_checks import assert_status
 from pytest_simcore.helpers.typing_env import EnvVarsDict
 from pytest_simcore.helpers.webserver_login import UserInfoDict, log_client_in
@@ -54,6 +59,7 @@
 from servicelib.aiohttp import status
 from servicelib.common_headers import UNDEFINED_DEFAULT_SIMCORE_USER_AGENT_VALUE
 from simcore_postgres_database.models.products import products
+from simcore_postgres_database.models.wallets import wallets
 from simcore_service_webserver._meta import API_VTAG
 from simcore_service_webserver.db.models import UserRole
 from simcore_service_webserver.projects.models import ProjectDict
@@ -71,7 +77,11 @@ def app_environment(
 ) -> EnvVarsDict:
     # disable the garbage collector
     monkeypatch.setenv("WEBSERVER_GARBAGE_COLLECTOR", "null")
-    return app_environment | {"WEBSERVER_GARBAGE_COLLECTOR": "null"}
+    monkeypatch.setenv("WEBSERVER_DEV_FEATURES_ENABLED", "1")
+    return app_environment | {
+        "WEBSERVER_GARBAGE_COLLECTOR": "null",
+        "WEBSERVER_DEV_FEATURES_ENABLED": "1",
+    }
 
 
 def assert_replaced(current_project, update_data):
@@ -405,6 +415,69 @@ async def test_open_project(
         mocked_notifications_plugin["subscribe"].assert_not_called()
 
 
+@pytest.fixture
+def wallets_clean_db(postgres_db: sa.engine.Engine) -> Iterator[None]:
+    with postgres_db.connect() as con:
+        yield
+        con.execute(wallets.delete())
+
+
+@pytest.mark.parametrize(
+    "user_role,expected,return_value_credits",
+    [
+        (UserRole.USER, status.HTTP_200_OK, Decimal(0)),
+        (UserRole.USER, status.HTTP_402_PAYMENT_REQUIRED, Decimal(-100)),
+    ],
+)
+async def test_open_project__in_debt(
+    client: TestClient,
+    logged_user: UserInfoDict,
+    user_project: ProjectDict,
+    client_session_id_factory: Callable[[], str],
+    expected: HTTPStatus,
+    mocked_dynamic_services_interface: dict[str, mock.Mock],
+    mock_service_resources: ServiceResourcesDict,
+    mock_orphaned_services: mock.Mock,
+    mock_catalog_api: dict[str, mock.Mock],
+    osparc_product_name: str,
+    mocked_notifications_plugin: dict[str, mock.Mock],
+    return_value_credits: Decimal,
+    mocker: MockerFixture,
+    wallets_clean_db: None,
+):
+    # create a new wallet
+    url = client.app.router["create_wallet"].url_for()
+    resp = await client.post(
+        f"{url}", json={"name": "My first wallet", "description": "Custom description"}
+    )
+    added_wallet, _ = await assert_status(resp, status.HTTP_201_CREATED)
+
+    mock_get_project_wallet_total_credits = mocker.patch(
+        "simcore_service_webserver.projects._wallets_api.credit_transactions.get_project_wallet_total_credits",
+        spec=True,
+        return_value=WalletTotalCredits(
+            wallet_id=added_wallet["walletId"],
+            available_osparc_credits=return_value_credits,
+        ),
+    )
+
+    # Connect project to a wallet
+    base_url = client.app.router["connect_wallet_to_project"].url_for(
+        project_id=user_project["uuid"], wallet_id=f"{added_wallet['walletId']}"
+    )
+    resp = await client.put(f"{base_url}")
+    data, _ = await assert_status(resp, status.HTTP_200_OK)
+    assert data["walletId"] == added_wallet["walletId"]
+
+    # POST /v0/projects/{project_id}:open
+    assert client.app
+    url = client.app.router["open_project"].url_for(project_id=user_project["uuid"])
+    resp = await client.post(f"{url}", json=client_session_id_factory())
+    await assert_status(resp, expected)
+
+    assert mock_get_project_wallet_total_credits.assert_called_once
+
+
 @pytest.mark.parametrize(
     "user_role,expected,save_state",
     [