Add more tests

Author: wvangeit

services/api-server/src/simcore_service_api_server/api/routes/functions_routes.py

@@ -25,7 +25,7 @@
 from models_library.functions_errors import (
     FunctionExecuteAccessDeniedError,
     FunctionInputsValidationError,
-    FunctionsExecuteAbilityDeniedError,
+    FunctionsExecuteApiAccessDeniedError,
     UnsupportedFunctionClassError,
 )
 from models_library.products import ProductName
@@ -380,7 +380,7 @@ async def run_function(  # noqa: PLR0913
         user_id=user_id, product_name=product_name
     )
     if not user_abilities.execute_functions:
-        raise FunctionsExecuteAbilityDeniedError(
+        raise FunctionsExecuteApiAccessDeniedError(
             user_id=user_id,
             function_id=function_id,
         )

services/api-server/tests/unit/api_functions/test_api_routers_functions.py

@@ -592,7 +592,10 @@ async def test_list_function_job_collections_with_function_filter(
 
 
 @pytest.mark.parametrize("user_has_execute_ability", [False, True])
-async def test_run_function_not_allowed(
+@pytest.mark.parametrize(
+    "funcapi_endpoint,endpoint_inputs", [("run", {}), ("map", [{}, {}])]
+)
+async def test_run_map_function_not_allowed(
     client: AsyncClient,
     mock_handler_in_functions_rpc_interface: Callable[[str, Any], None],
     mock_registered_function: RegisteredProjectFunction,
@@ -601,6 +604,8 @@ async def test_run_function_not_allowed(
     mocked_webserver_rest_api_base: respx.MockRouter,
     mocked_webserver_rpc_api: dict[str, MockType],
     user_has_execute_ability: bool,
+    funcapi_endpoint: str,
+    endpoint_inputs: dict | list[dict],
 ) -> None:
     """Test that running a function is not allowed."""
 
@@ -631,8 +636,8 @@ async def async_magic():
     MagicMock.__await__ = lambda _: async_magic().__await__()
 
     response = await client.post(
-        f"{API_VTAG}/functions/{mock_registered_function.uid}:run",
-        json={},
+        f"{API_VTAG}/functions/{mock_registered_function.uid}:{funcapi_endpoint}",
+        json=endpoint_inputs,
         auth=auth,
     )
     if user_has_execute_ability:

services/web/server/tests/unit/with_dbs/04/functions_rpc/test_functions_controller_rest.py

@@ -49,7 +49,7 @@ def mock_function() -> dict[str, Any]:
 
 
 @pytest.mark.parametrize(
-    "user_role,add_user_functions_abilities,expected_register,expected_get,expected_delete,expected_get2",
+    "user_role,add_user_function_api_access_rights,expected_register,expected_get,expected_delete,expected_get2",
     [
         (
             UserRole.USER,
@@ -68,7 +68,7 @@ def mock_function() -> dict[str, Any]:
             status.HTTP_403_FORBIDDEN,
         ),
     ],
-    indirect=["add_user_functions_abilities"],
+    indirect=["add_user_function_api_access_rights"],
 )
 async def test_register_get_delete_function(
     client: TestClient,
@@ -78,7 +78,7 @@ async def test_register_get_delete_function(
     expected_get: HTTPStatus,
     expected_delete: HTTPStatus,
     expected_get2: HTTPStatus,
-    add_user_functions_abilities: AsyncIterator[None],
+    add_user_function_api_access_rights: AsyncIterator[None],
     request: pytest.FixtureRequest,
 ) -> None:
     url = client.app.router["register_function"].url_for()