review

Author: matusdrobuliak66

services/web/server/src/simcore_service_webserver/fogbugz/_client.py

@@ -13,7 +13,7 @@
 
 from ..products import products_service
 from ..products.models import Product
-from .settings import FogbugzSettings, get_plugin_settings
+from .settings import get_plugin_settings
 
 _logger = logging.getLogger(__name__)
 
@@ -164,11 +164,7 @@ async def reopen_case(self, case_id: str, assigned_fogbugz_person_id: str) -> No
 
 async def setup_fogbugz_rest_client(app: web.Application) -> None:
     """Setup Fogbugz REST client"""
-    settings: FogbugzSettings | None = get_plugin_settings(app)
-
-    if settings is None:
-        _logger.warning("Fogbugz settings not configured, skipping setup")
-        return
+    settings = get_plugin_settings(app)
 
     # Fail fast if unexpected configuration
     products: list[Product] = products_service.list_products(app=app)

services/web/server/src/simcore_service_webserver/fogbugz/settings.py

@@ -11,6 +11,6 @@ class FogbugzSettings(BaseCustomSettings):
 
 def get_plugin_settings(app: web.Application) -> FogbugzSettings:
     settings = app[APP_SETTINGS_KEY].WEBSERVER_FOGBUGZ
-    assert settings, "setup_settings not called?"  # nosec
+    assert settings, "plugin.setup_fogbugz not called?"  # nosec
     assert isinstance(settings, FogbugzSettings)  # nosec
     return settings

services/web/server/tests/unit/with_dbs/04/test_fogbugz_client.py

@@ -81,7 +81,7 @@ def mock_fogbugz_api(fake_api_base_url: str) -> Iterator[respx.MockRouter]:
         yield mock
 
 
-async def test_testit(
+async def test_fogubugz_client(
     app_environment: EnvVarsDict,
     client: TestClient,
     mock_fogbugz_api: respx.MockRouter,