Skip to content

Commit df99b2d

Browse files
author
Andrei Neagu
committed
catch if volumes were not removed, not important if it fails
1 parent 4fda161 commit df99b2d

File tree

1 file changed

+12
-6
lines changed
  • services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core

1 file changed

+12
-6
lines changed

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_utils.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@
2828
from servicelib.logging_utils import log_context
2929
from servicelib.rabbitmq import RabbitMQClient
3030
from servicelib.rabbitmq._client_rpc import RabbitMQRPCClient
31+
from servicelib.rabbitmq.rpc_interfaces.agent.errors import (
32+
NoServiceVolumesFoundRPCError,
33+
)
3134
from servicelib.rabbitmq.rpc_interfaces.agent.volumes import (
3235
remove_volumes_without_backup_for_service,
3336
)
@@ -234,12 +237,15 @@ async def service_remove_sidecar_proxy_docker_networks_and_volumes(
234237
)
235238
with log_context(_logger, logging.DEBUG, f"removing volumes '{node_uuid}'"):
236239
rabbit_rpc_client: RabbitMQRPCClient = app.state.rabbitmq_rpc_client
237-
await remove_volumes_without_backup_for_service(
238-
rabbit_rpc_client,
239-
docker_node_id=scheduler_data.dynamic_sidecar.docker_node_id,
240-
swarm_stack_name=swarm_stack_name,
241-
node_id=scheduler_data.node_uuid,
242-
)
240+
try:
241+
await remove_volumes_without_backup_for_service(
242+
rabbit_rpc_client,
243+
docker_node_id=scheduler_data.dynamic_sidecar.docker_node_id,
244+
swarm_stack_name=swarm_stack_name,
245+
node_id=scheduler_data.node_uuid,
246+
)
247+
except NoServiceVolumesFoundRPCError as e:
248+
_logger.info("Could not remove volumes, reason: %s", e)
243249

244250
_logger.debug(
245251
"Removed dynamic-sidecar services and crated container for '%s'",

0 commit comments

Comments
 (0)