Skip to content

Commit e060b0f

Browse files
committed
cleanup
1 parent 53951c0 commit e060b0f

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

packages/service-library/src/servicelib/aiohttp/db_asyncpg_engine.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,15 @@ def get_async_engine(app: web.Application) -> AsyncEngine:
4040

4141

4242
async def connect_to_db(app: web.Application, settings: PostgresSettings) -> None:
43+
"""
44+
- db services up, data migrated and ready to use
45+
- sets an engine in app state (use `get_async_engine(app)` to retrieve)
46+
"""
47+
if settings.POSTGRES_CLIENT_NAME:
48+
settings = settings.copy(
49+
update={"POSTGRES_CLIENT_NAME": settings.POSTGRES_CLIENT_NAME + "-asyncpg"}
50+
)
51+
4352
engine = await create_async_engine_and_pg_database_ready(settings)
4453
_set_async_engine_to_app_state(app, engine)
4554

packages/service-library/src/servicelib/db_asyncpg_utils.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,12 @@
2222
async def create_async_engine_and_pg_database_ready(
2323
settings: PostgresSettings,
2424
) -> AsyncEngine:
25+
"""
26+
- creates asynio engine
27+
- waits until db service is up
28+
- waits until db data is migrated (i.e. ready to use)
29+
- returns engine
30+
"""
2531
with log_context(
2632
_logger, logging.DEBUG, f"connection to db {settings.dsn_with_async_sqlalchemy}"
2733
):

0 commit comments

Comments
 (0)