reverted

Author: pcrespov

packages/common-library/src/common_library/errors_classes.py

@@ -52,30 +52,3 @@ def error_context(self) -> dict[str, Any]:
     def error_code(self) -> str:
         assert isinstance(self, Exception), "subclass must be exception"  # nosec
         return create_error_code(self)
-
-
-class NotFoundError(OsparcErrorMixin):
-    msg_template = "{resource} not found: id='{resource_id}'"
-
-
-class ForbiddenError(OsparcErrorMixin):
-    msg_template = "Access to {resource} is forbidden: id='{resource_id}'"
-
-
-def make_resource_error(
-    resource: str,
-    error_cls: type[OsparcErrorMixin],
-    base_exception: type[Exception] = Exception,
-) -> type[Exception]:
-    class _ResourceError(error_cls, base_exception):
-        def __init__(self, **ctx: Any):
-            ctx.setdefault("resource", resource)
-            # guesses identifer e.g. project_id, user_id
-            if resource_id := ctx.get(f"{resource.lower()}_id"):
-                ctx.setdefault("resource_id", resource_id)
-
-            super().__init__(**ctx)
-
-    resource_class_name = "".join(word.capitalize() for word in resource.split("_"))
-    _ResourceError.__name__ = f"{resource_class_name}{error_cls.__name__}"
-    return _ResourceError

packages/common-library/tests/test_errors_classes.py

@@ -9,12 +9,7 @@
 from typing import Any
 
 import pytest
-from common_library.errors_classes import (
-    ForbiddenError,
-    NotFoundError,
-    OsparcErrorMixin,
-    make_resource_error,
-)
+from common_library.errors_classes import OsparcErrorMixin
 
 
 def test_get_full_class_name():
@@ -159,44 +154,3 @@ class MyError(OsparcErrorMixin, ValueError):
         "message": "42 and 'missing=?'",
         "value": 42,
     }
-
-
-def test_resource_error_factory():
-    ProjectNotFoundError = make_resource_error("project", NotFoundError)
-
-    error_1 = ProjectNotFoundError(resource_id="abc123")
-    assert "resource_id" in error_1.error_context()
-    assert error_1.resource_id in error_1.message  # type: ignore
-
-
-def test_resource_error_factory_auto_detect_resource_id():
-    ProjectForbiddenError = make_resource_error("project", ForbiddenError)
-    error_2 = ProjectForbiddenError(project_id="abc123", other_id="foo")
-    assert (
-        error_2.resource_id == error_2.project_id  # type: ignore
-    ), "auto-detects project ids as resourceid"
-    assert error_2.other_id  # type: ignore
-    assert error_2.code == "ForbiddenError.ProjectForbiddenError"
-
-    assert error_2.error_context() == {
-        "project_id": "abc123",
-        "other_id": "foo",
-        "resource": "project",
-        "resource_id": "abc123",
-        "message": "Access to project is forbidden: id='abc123'",
-        "code": "ForbiddenError.ProjectForbiddenError",
-    }
-
-
-def test_resource_error_factory_different_base_exception():
-
-    class MyBaseError(Exception): ...
-
-    OtherProjectForbiddenError = make_resource_error(
-        "other_project", ForbiddenError, MyBaseError
-    )
-
-    assert issubclass(OtherProjectForbiddenError, MyBaseError)
-
-    error_3 = OtherProjectForbiddenError(project_id="abc123")
-    assert error_3.code == "MyBaseError.ForbiddenError.OtherProjectForbiddenError"