Skip to content

Commit e21037e

Browse files
authored
Merge branch 'master' into enh/user-notifications
2 parents 8ca9802 + 24445c0 commit e21037e

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

services/static-webserver/client/source/class/osparc/store/Services.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ qx.Class.define("osparc.store.Services", {
5959
let serviceLatest = servicesLatest[key];
6060
if (excludeFrontend && key.includes("simcore/services/frontend/")) {
6161
// do not add frontend services
62-
return;
62+
continue;
6363
}
6464
if (excludeDeprecated && serviceLatest["retired"]) {
6565
// first check if a previous version of this service isn't retired
@@ -68,13 +68,14 @@ qx.Class.define("osparc.store.Services", {
6868
for (let j=0; j<versions.length; j++) {
6969
const version = versions[j];
7070
if (!this.servicesCached[key][version]["retired"]) {
71+
// one older non retired version found
7172
serviceLatest = await this.getService(key, version);
7273
break;
7374
}
7475
}
7576
if (serviceLatest["retired"]) {
7677
// do not add retired services
77-
return;
78+
continue;
7879
}
7980
}
8081
servicesList.push(serviceLatest);

services/static-webserver/client/source/class/osparc/utils/Utils.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -720,12 +720,14 @@ qx.Class.define("osparc.utils.Utils", {
720720
if (!+bytes) {
721721
return "0 Bytes";
722722
}
723+
723724
const k = 1000;
724-
const sizes = ["Bytes", "KB", "MB", "GB", "TB"];
725725
const dm = decimals < 0 ? 0 : decimals;
726-
727-
const i = Math.floor(Math.log(bytes) / Math.log(k))
728-
return `${isDecimalCollapsed ? parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) : (bytes / Math.pow(k, i)).toFixed(dm)} ${sizes[i]}`
726+
const i = Math.floor(Math.log(bytes) / Math.log(k));
727+
const value = (bytes / Math.pow(k, i)).toFixed(dm);
728+
const metrics = ["Bytes", "kB", "MB", "GB", "TB"];
729+
const metric = i < metrics.length ? metrics[i] : "";
730+
return `${isDecimalCollapsed ? parseFloat(value) : value} ${metric}`
729731
},
730732

731733
bytesToGB: function(bytes) {

0 commit comments

Comments
 (0)