final cleanup before introducing dag list field to comp_runs

Author: matusdrobuliak66

services/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_runs.py

@@ -14,7 +14,6 @@
 from models_library.users import UserID
 from models_library.utils.fastapi_encoders import jsonable_encoder
 from pydantic import PositiveInt
-from simcore_postgres_database.utils_comp_runs import get_latest_run_id_for_project
 from simcore_postgres_database.utils_repos import (
     pass_or_acquire_connection,
     transaction_context,
@@ -351,16 +350,6 @@ async def list_for_user_and_project_all_iterations(
 
             return cast(int, total_count), items
 
-    async def get_latest_run_id_for_project(
-        self,
-        conn: AsyncConnection | None = None,
-        *,
-        project_id: ProjectID,
-    ) -> PositiveInt:
-        return await get_latest_run_id_for_project(
-            self.db_engine, conn, project_id=f"{project_id}"
-        )
-
     async def create(
         self,
         *,

services/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_runs_snapshot_tasks.py

@@ -33,29 +33,6 @@ async def batch_create(
                     ),
                     data,
                 )
-                # rows = result.fetchall()
-                # return [CompRunSnapshotTaskAtDBGet.model_validate(row) for row in rows]
-            except Exception as e:
-                logger.error(
-                    "Failed to batch create comp run snapshot tasks: %s",
-                    e,
-                    exc_info=True,
-                )
+            except Exception:
+                logger.exception("Failed to batch create comp run snapshot tasks")
                 raise
-
-    # async def update_for_run_id_and_node_id(
-    #     self,
-    #     connection: AsyncConnection | None = None,
-    #     *,
-    #     run_id: PositiveInt,
-    #     node_id: NodeID,
-    #     data: dict,
-    # ) -> CompRunSnapshotTaskAtDBGet:
-    #     row = await update_for_run_id_and_node_id(
-    #         self.db_engine,
-    #         conn=connection,
-    #         run_id=run_id,
-    #         node_id=f"{node_id}",
-    #         data=data,
-    #     )
-    #     return CompRunSnapshotTaskAtDBGet.model_validate(row)

services/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_tasks/_core.py

@@ -200,8 +200,6 @@ async def upsert_tasks_from_project(
             # NOTE: comp_tasks DB only trigger a notification to the webserver if an UPDATE on comp_tasks.outputs or comp_tasks.state is done
             # NOTE: an exception to this is when a frontend service changes its output since there is no node_ports, the UPDATE must be done here.
 
-            # NOTE: MD here I do not need to update the new db table!!! (remove this comment)
-
             inserted_comp_tasks_db: list[CompTaskAtDB] = []
             for comp_task_db in list_of_comp_tasks_in_project:
                 insert_stmt = insert(comp_tasks).values(
@@ -277,8 +275,6 @@ async def _update_task(
     async def mark_project_published_waiting_for_cluster_tasks_as_aborted(
         self, project_id: ProjectID, run_id: PositiveInt
     ) -> None:
-        # NOTE: MD here is creation/update of comp_tasks table
-
         # block all pending tasks, so the sidecars stop taking them
         async with self.db_engine.begin() as conn:
             await conn.execute(