Skip to content

Commit e2f1607

Browse files
committed
currentNodeId more progress
1 parent 9e342cf commit e2f1607

File tree

4 files changed

+54
-12
lines changed

4 files changed

+54
-12
lines changed

services/static-webserver/client/source/class/osparc/data/model/IframeHandler.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,13 @@ qx.Class.define("osparc.data.model.IframeHandler", {
108108
const loadingPage = new osparc.ui.message.Loading().set({
109109
header: this.__getLoadingPageHeader()
110110
});
111+
if (osparc.product.Utils.isProduct("s4llite")) {
112+
loadingPage.setShowToolbar(false);
113+
} else {
114+
this.getStudy().getUi().bind("mode", loadingPage, "showToolbar", {
115+
converter: mode => mode !== "standalone"
116+
});
117+
}
111118

112119
const node = this.getNode();
113120
const thumbnail = node.getMetaData()["thumbnail"];

services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,12 @@ qx.Class.define("osparc.desktop.StudyEditor", {
716716
this.__viewsStack.setSelection([this.__workbenchView]);
717717
const currentNodeId = this.getStudy().getUi().getCurrentNodeId();
718718
if (currentNodeId) {
719-
this.__workbenchView.nodeSelected(currentNodeId);
719+
const node = this.getStudy().getWorkbench().getNode(currentNodeId);
720+
if (node && node.isDynamic()) {
721+
this.__workbenchView.fullscreenNode(currentNodeId);
722+
} else {
723+
this.__workbenchView.nodeSelected(currentNodeId);
724+
}
720725
} else {
721726
this.__workbenchView.openFirstNode();
722727
}

services/static-webserver/client/source/class/osparc/desktop/WorkbenchView.js

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -503,6 +503,8 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
503503
this.__evalIframe();
504504
this.__openWorkbenchTab();
505505
this.__loggerView.setCurrentNodeId(null);
506+
507+
this.getStudy().getUi().setCurrentNodeId(this.getStudy().getUuid());
506508
});
507509
nodesTree.addListener("changeSelectedNode", e => {
508510
studyTreeItem.resetSelection();
@@ -516,6 +518,8 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
516518
this.__loggerView.setCurrentNodeId(nodeId);
517519
this.__workbenchUI.nodeSelected(nodeId);
518520
this.fireDataEvent("changeSelectedNode", nodeId);
521+
522+
this.getStudy().getUi().setCurrentNodeId(nodeId);
519523
});
520524

521525
if (this.__workbenchUIConnected === null) {
@@ -531,9 +535,13 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
531535
this.__evalIframe(node);
532536
this.__loggerView.setCurrentNodeId(nodeId);
533537
this.fireDataEvent("changeSelectedNode", nodeId);
538+
539+
this.getStudy().getUi().setCurrentNodeId(nodeId);
534540
} else {
535541
// empty selection
536542
this.__studyTreeItem.selectStudyItem();
543+
544+
this.getStudy().getUi().setCurrentNodeId(this.getStudy().getUuid());
537545
}
538546
});
539547
workbenchUI.addListener("nodeSelected", e => {
@@ -547,6 +555,8 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
547555
this.__populateSecondaryColumn(node);
548556
this.__openIframeTab(node);
549557
this.__loggerView.setCurrentNodeId(nodeId);
558+
559+
this.getStudy().getUi().setCurrentNodeId(nodeId);
550560
}
551561
}, this);
552562
}
@@ -564,6 +574,8 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
564574
}
565575
this.__loggerView.setCurrentNodeId(nodeId);
566576
this.__workbenchUI.nodeSelected(nodeId);
577+
578+
this.getStudy().getUi().setCurrentNodeId(nodeId);
567579
}
568580
}, this);
569581
nodesTree.addListener("removeNode", e => {
@@ -1184,19 +1196,25 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
11841196
this.__nodesTree.nodeSelected(this.__currentNodeId);
11851197
},
11861198

1199+
fullscreenNode: function(nodeId) {
1200+
const node = this.getStudy().getWorkbench().getNode(nodeId);
1201+
if (node.isDynamic()) {
1202+
qx.event.Timer.once(() => {
1203+
this.__openIframeTab(node);
1204+
node.getIFrame().maximizeIFrame(true);
1205+
}, this, 10);
1206+
}
1207+
},
1208+
11871209
openFirstNode: function() {
11881210
const validNodes = this.getStudy().getNonFrontendNodes();
11891211
if (validNodes.length === 1 && validNodes[0].isDynamic()) {
11901212
const dynamicNode = validNodes[0];
1191-
this.nodeSelected(dynamicNode.getNodeId());
1192-
qx.event.Timer.once(() => {
1193-
this.__openIframeTab(dynamicNode);
1194-
dynamicNode.getIFrame().maximizeIFrame(true);
1195-
}, this, 10);
1196-
return;
1213+
this.fullscreenNode(dynamicNode.getNodeId());
1214+
} else {
1215+
this.setMaximized(false);
1216+
this.nodeSelected(this.getStudy().getUuid());
11971217
}
1198-
this.setMaximized(false);
1199-
this.nodeSelected(this.getStudy().getUuid());
12001218
}
12011219
}
12021220
});

services/static-webserver/client/source/class/osparc/ui/message/Loading.js

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,15 @@ qx.Class.define("osparc.ui.message.Loading", {
6767
nullable: true,
6868
apply: "__applyMessages"
6969
},
70+
71+
/**
72+
* Show Restart-Maximize Toolbar
73+
*/
74+
showToolbar: {
75+
check: "Boolean",
76+
init: false,
77+
event: "changeShowToolbar",
78+
}
7079
},
7180

7281
events: {
@@ -206,11 +215,14 @@ qx.Class.define("osparc.ui.message.Loading", {
206215
osparc.utils.Utils.setIdToWidget(maxButton, osparc.widget.PersistentIframe.getMaximizeWidgetId(maximize));
207216
maxButton.addListener("execute", () => this.maximizeIFrame(!this.hasState("maximized")), this);
208217

209-
const maximizeLayout = new qx.ui.container.Composite(new qx.ui.layout.HBox().set({
218+
const toolbarLayout = new qx.ui.container.Composite(new qx.ui.layout.HBox().set({
210219
alignX: "right",
211220
}));
212-
maximizeLayout.add(maxButton);
213-
return maximizeLayout;
221+
this.bind("showToolbar", toolbarLayout, "visibility", {
222+
converter: showToolbar => showToolbar ? "visible" : "hidden"
223+
});
224+
toolbarLayout.add(maxButton);
225+
return toolbarLayout;
214226
},
215227

216228
__applyLogo: function(newLogo) {

0 commit comments

Comments
 (0)