Skip to content

Commit e38545b

Browse files
committed
simplify
1 parent e4cc8a6 commit e38545b

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_base.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -590,9 +590,7 @@ async def _process_executing_tasks(
590590
"""process executing tasks from the 3rd party backend"""
591591

592592
@abstractmethod
593-
async def _release_resources(
594-
self, user_id: UserID, project_id: ProjectID, comp_run: CompRunsAtDB
595-
) -> None:
593+
async def _release_resources(self, comp_run: CompRunsAtDB) -> None:
596594
"""release resources used by the scheduler for a given user and project"""
597595

598596
async def apply(
@@ -660,7 +658,7 @@ async def apply(
660658

661659
# 7. Are we done scheduling that pipeline?
662660
if not dag.nodes() or pipeline_result in COMPLETED_STATES:
663-
await self._release_resources(user_id, project_id, comp_run)
661+
await self._release_resources(comp_run)
664662
# there is nothing left, the run is completed, we're done here
665663
_logger.info(
666664
"pipeline %s scheduling completed with result %s",

services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_dask.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -232,21 +232,21 @@ async def _process_executing_tasks(
232232
)
233233
)
234234

235-
async def _release_resources(
236-
self, user_id: UserID, project_id: ProjectID, comp_run: CompRunsAtDB
237-
) -> None:
235+
async def _release_resources(self, comp_run: CompRunsAtDB) -> None:
238236
"""release resources used by the scheduler for a given user and project"""
239237
with (
240238
log_catch(_logger, reraise=False),
241239
log_context(
242240
_logger,
243241
logging.INFO,
244-
msg=f"releasing resources for {user_id=}, {project_id=}, {comp_run.run_id=}",
242+
msg=f"releasing resources for {comp_run.user_id=}, {comp_run.project_uuid=}, {comp_run.run_id=}",
245243
),
246244
):
247245
await self.dask_clients_pool.release_client_ref(
248246
ref=_DASK_CLIENT_RUN_REF.format(
249-
user_id=user_id, project_id=project_id, run_id=comp_run.run_id
247+
user_id=comp_run.user_id,
248+
project_id=comp_run.project_uuid,
249+
run_id=comp_run.run_id,
250250
)
251251
)
252252

0 commit comments

Comments
 (0)