@GitHK review: checks

Author: pcrespov

packages/models-library/src/models_library/service_settings_labels.py

@@ -335,7 +335,7 @@ class DynamicSidecarServiceLabels(BaseModel):
     callbacks_mapping: Annotated[
         Json[CallbacksMapping] | None,
         Field(
-            default_factory=CallbacksMapping,  # this one ANE I am not sure about
+            default_factory=CallbacksMapping,  # NOTE: PC->ANE I still think this could be an issue
             alias="simcore.service.callbacks-mapping",
             description="exposes callbacks from user services to the sidecar",
         ),

packages/models-library/src/models_library/user_preferences.py

@@ -4,6 +4,7 @@
 from common_library.pydantic_fields_extension import get_type
 from pydantic import BaseModel, Field
 from pydantic._internal._model_construction import ModelMetaclass
+from pydantic.fields import FieldInfo
 
 from .services import ServiceKey, ServiceVersion
 from .utils.enums import StrAutoEnum
@@ -74,11 +75,12 @@ def get_preference_name(cls) -> PreferenceName:
 
     @classmethod
     def get_default_value(cls) -> Any:
-        # ANE: please double check this concept
+        value_field: FieldInfo = dict(cls.model_fields)["value"]
+
         return (
-            cls.model_fields["value"].default_factory()  # type: ignore[call-arg]
-            if cls.model_fields["value"].default_factory is not None
-            else cls.model_fields["value"].default
+            value_field.default_factory()  # type: ignore[call-arg]
+            if callable(value_field.default_factory)
+            else value_field.default
         )