after socketio update the enter_room and leave_room functions are coroutines

Author: sanderegg

packages/pytest-simcore/src/pytest_simcore/socketio.py

@@ -106,14 +106,14 @@ def socketio_server_events(
     # handlers
     async def connect(sid: str, environ):
         print("connecting", sid)
-        socketio_server.enter_room(sid, room_name)
+        await socketio_server.enter_room(sid, room_name)
 
     async def on_check(sid, data):
         print("check", sid, data)
 
     async def disconnect(sid: str):
         print("disconnecting", sid)
-        socketio_server.leave_room(sid, room_name)
+        await socketio_server.leave_room(sid, room_name)
 
     # spies
     spy_connect = mocker.AsyncMock(wraps=connect)

services/web/server/src/simcore_service_webserver/projects/_controller/projects_states_rest.py

@@ -129,7 +129,7 @@ async def open_project(request: web.Request) -> web.Response:
                 )
             )
         sio = get_socket_server(request.app)
-        sio.enter_room(
+        await sio.enter_room(
             _socket_id, SocketIORoomStr.from_project_id(path_params.project_id)
         )
 

services/web/server/src/simcore_service_webserver/socketio/_handlers.py

@@ -94,10 +94,9 @@ async def _set_user_in_group_rooms(
 
     sio = get_socket_server(app)
     for gid in group_ids:
-        # NOTE socketio need to be upgraded that's why enter_room is not an awaitable
-        sio.enter_room(socket_id, SocketIORoomStr.from_group_id(gid))
+        await sio.enter_room(socket_id, SocketIORoomStr.from_group_id(gid))
 
-    sio.enter_room(socket_id, SocketIORoomStr.from_user_id(user_id))
+    await sio.enter_room(socket_id, SocketIORoomStr.from_user_id(user_id))
 
 
 #