adds all monitoring and profiling

Author: pcrespov

services/web/server/src/simcore_service_webserver/application.py

@@ -194,20 +194,23 @@ def create_application() -> web.Application:
 
 def create_application_auth() -> web.Application:
     app = create_safe_application()
-    settings = setup_settings(app, app_name="simcore_service_wb_auth")
 
+    settings = setup_settings(app, app_name="simcore_service_wb_auth")
     assert settings.WEBSERVER_APP_FACTORY_NAME == "WEBSERVER_AUTHZ_APP_FACTORY"  # nosec
     assert settings.APP_NAME == "simcore_service_wb_auth"  # nosec
 
+    # Monitoring and diagnostics
     setup_app_tracing(
-        # NOTE: uses settings.APP_NAME
         # WARNING: must be UPPERMOST middleware
+        # NOTE: uses settings.APP_NAME
         app
     )
+    setup_diagnostics(app)
+    setup_profiling_middleware(app)
 
+    # Core modules
     setup_rest(app)
     setup_db(app)
-
     setup_login_auth(app)
 
     # NOTE: *last* events

services/web/server/src/simcore_service_webserver/diagnostics/plugin.py

@@ -33,7 +33,7 @@ async def _on_healthcheck_async_adapter(app: web.Application) -> None:
     settings_name="WEBSERVER_DIAGNOSTICS",
     logger=_logger,
 )
-def setup_diagnostics(app: web.Application) -> None:
+def setup_diagnostics(app: web.Application):
     setup_rest(app)
 
     settings: DiagnosticsSettings = get_plugin_settings(app)
@@ -58,8 +58,12 @@ def setup_diagnostics(app: web.Application) -> None:
     app[HEALTH_PLUGIN_START_TIME] = time.time()
 
 
-def setup_profiling_middleware(
-    app: web.Application,
-) -> None:
-    if get_application_settings(app).WEBSERVER_PROFILING:
-        app.middlewares.append(profiling_middleware)
+@app_module_setup(
+    __name__,
+    ModuleCategory.ADDON,
+    settings_name="WEBSERVER_PROFILING",
+    logger=_logger,
+)
+def setup_profiling_middleware(app: web.Application):
+    assert get_application_settings(app).WEBSERVER_PROFILING  # nosec
+    app.middlewares.append(profiling_middleware)