Skip to content

Commit e77282d

Browse files
fix mypy
1 parent b606934 commit e77282d

File tree

4 files changed

+23
-13
lines changed

4 files changed

+23
-13
lines changed

services/clusters-keeper/src/simcore_service_clusters_keeper/_meta.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,21 @@
99

1010
from models_library.basic_types import VersionStr, VersionTag
1111
from packaging.version import Version
12-
from pydantic import parse_obj_as
12+
from pydantic import TypeAdapter
1313

1414
_current_distribution = distribution("simcore-service-clusters-keeper")
1515
__version__: str = version("simcore-service-clusters-keeper")
1616

1717

1818
APP_NAME: Final[str] = _current_distribution.metadata["Name"]
19-
API_VERSION: Final[VersionStr] = parse_obj_as(VersionStr, __version__)
19+
API_VERSION: Final[VersionStr] = TypeAdapter(VersionStr).validate_python(__version__)
2020
VERSION: Final[Version] = Version(__version__)
21-
API_VTAG: Final[VersionTag] = parse_obj_as(VersionTag, f"v{VERSION.major}")
22-
RPC_VTAG: Final[VersionTag] = parse_obj_as(VersionTag, f"v{VERSION.major}")
21+
API_VTAG: Final[VersionTag] = TypeAdapter(VersionTag).validate_python(
22+
f"v{VERSION.major}"
23+
)
24+
RPC_VTAG: Final[VersionTag] = TypeAdapter(VersionTag).validate_python(
25+
f"v{VERSION.major}"
26+
)
2327

2428

2529
def get_summary() -> str:

services/clusters-keeper/src/simcore_service_clusters_keeper/modules/clusters_management_core.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from fastapi import FastAPI
99
from models_library.users import UserID
1010
from models_library.wallets import WalletID
11-
from pydantic import parse_obj_as
11+
from pydantic import TypeAdapter
1212
from servicelib.logging_utils import log_catch
1313

1414
from ..core.settings import get_application_settings
@@ -35,8 +35,10 @@ def _get_instance_last_heartbeat(instance: EC2InstanceData) -> datetime.datetime
3535
return None
3636

3737

38-
_USER_ID_TAG_KEY: Final[AWSTagKey] = parse_obj_as(AWSTagKey, "user_id")
39-
_WALLET_ID_TAG_KEY: Final[AWSTagKey] = parse_obj_as(AWSTagKey, "wallet_id")
38+
_USER_ID_TAG_KEY: Final[AWSTagKey] = TypeAdapter(AWSTagKey).validate_python("user_id")
39+
_WALLET_ID_TAG_KEY: Final[AWSTagKey] = TypeAdapter(AWSTagKey).validate_python(
40+
"wallet_id"
41+
)
4042

4143

4244
async def _get_all_associated_worker_instances(

services/clusters-keeper/src/simcore_service_clusters_keeper/utils/dask.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
from aws_library.ec2 import EC2InstanceData
22
from fastapi import FastAPI
33
from models_library.clusters import InternalClusterAuthentication
4-
from pydantic import AnyUrl, parse_obj_as
4+
from pydantic import AnyUrl, TypeAdapter
55

66
from ..core.settings import get_application_settings
77

88

99
def get_scheduler_url(ec2_instance: EC2InstanceData) -> AnyUrl:
10-
url: AnyUrl = parse_obj_as(AnyUrl, f"tls://{ec2_instance.aws_private_dns}:8786")
10+
url: AnyUrl = TypeAdapter(AnyUrl).validate_python(
11+
f"tls://{ec2_instance.aws_private_dns}:8786"
12+
)
1113
return url
1214

1315

services/clusters-keeper/src/simcore_service_clusters_keeper/utils/ec2.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,19 @@
44
from aws_library.ec2 import AWSTagKey, AWSTagValue, EC2Tags
55
from models_library.users import UserID
66
from models_library.wallets import WalletID
7-
from pydantic import parse_obj_as
7+
from pydantic import TypeAdapter
88

99
from .._meta import VERSION
1010
from ..core.settings import ApplicationSettings
1111

1212
_APPLICATION_TAG_KEY: Final[str] = "io.simcore.clusters-keeper"
13-
_APPLICATION_VERSION_TAG: Final[EC2Tags] = parse_obj_as(
14-
EC2Tags, {f"{_APPLICATION_TAG_KEY}.version": f"{VERSION}"}
13+
_APPLICATION_VERSION_TAG: Final[EC2Tags] = TypeAdapter(EC2Tags).validate_python(
14+
{f"{_APPLICATION_TAG_KEY}.version": f"{VERSION}"}
1515
)
1616

17-
HEARTBEAT_TAG_KEY: Final[AWSTagKey] = parse_obj_as(AWSTagKey, "last_heartbeat")
17+
HEARTBEAT_TAG_KEY: Final[AWSTagKey] = TypeAdapter(AWSTagKey).validate_python(
18+
"last_heartbeat"
19+
)
1820
CLUSTER_NAME_PREFIX: Final[str] = "osparc-computational-cluster-"
1921

2022

0 commit comments

Comments
 (0)