copilot feedback

Author: Andrei Neagu

packages/service-library/src/servicelib/long_running_interfaces/_client.py

@@ -294,7 +294,7 @@ async def ensure_result(  # type: ignore[valid-type]
             ) from e
         finally:
             # when completed remove the task form memory both on the server and the client
-            # TODO: unsure if these should be caught and ingored, if we want to catch them both
-            # shoudl support some automatic cleanup in case the are forgotten
+            # NOTE: unsure if these should be caught and ingored. In the case we decide to
+            # catch them there should be some automatic cleanup in case the are forgotten
             await self._rpc_interface.remove(unique_id)
             await self._store_interface.remove(unique_id)

packages/service-library/src/servicelib/long_running_interfaces/_errors.py

@@ -30,7 +30,7 @@ class AlreadyStartedError(BaseLongRunningError):
 
 
 class JobNotFoundError(BaseLongRunningError):
-    msg_template = "unique_id='{unique_id}' is not presnet"
+    msg_template = "unique_id='{unique_id}' is not present"
 
 
 class NoResultIsAvailableError(BaseLongRunningError):

packages/service-library/src/servicelib/long_running_interfaces/_rpc/_utils.py

@@ -6,7 +6,7 @@
 _RPC_NAME: Final[str] = "long_running_interface"
 
 
-def get_rpc_namespace(long_running_namepsace: LongRunningNamespace) -> RPCNamespace:
+def get_rpc_namespace(long_running_namespace: LongRunningNamespace) -> RPCNamespace:
     return RPCNamespace.from_entries(
-        {"name": _RPC_NAME, "long_running_namepsace": long_running_namepsace}
+        {"name": _RPC_NAME, "long_running_namespace": long_running_namespace}
     )

packages/service-library/tests/long_running_interfaces/test__rpc.py

@@ -87,7 +87,7 @@ async def start(
         params: StartParams,
         timeout: timedelta,  # noqa: ASYNC109
     ) -> None:
-        print(f"starging {name}")
+        print(f"starting {name}")
         self._storage[unique_id] = {
             "params": params,
             "time_remaining": int(timeout.total_seconds()),

services/web/server/src/simcore_service_webserver/projects/_projects_service.py

@@ -1200,7 +1200,7 @@ async def is_node_id_present_in_any_project_workbench(
     app: web.Application,
     node_id: NodeID,
 ) -> bool:
-    """If the node_id is presnet in one of the projects' workbenche returns True"""
+    """If the node_id is present in one of the projects' workbenche returns True"""
     db: ProjectDBAPI = app[APP_PROJECT_DBAPI]
     return await db.node_id_exists(node_id)