Skip to content

Commit e8b8996

Browse files
committed
@GitHK review: exception
1 parent 45b8767 commit e8b8996

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

services/api-server/src/simcore_service_api_server/_service_solvers.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
from models_library.services_history import ServiceRelease
1313
from models_library.users import UserID
1414
from packaging.version import Version
15+
from simcore_service_api_server.exceptions.custom_errors import (
16+
SolverServiceListJobsFiltersError,
17+
)
1518

1619
from .models.api_resources import compose_resource_name
1720
from .models.schemas.jobs import Job, JobInputs
@@ -110,8 +113,7 @@ async def list_jobs(
110113
collection_or_resource_ids.append("releases")
111114
collection_or_resource_ids.append(solver_version)
112115
elif solver_version:
113-
msg = "solver_version is set but solver_id is not. Please provide both or none of them"
114-
raise ValueError(msg)
116+
raise SolverServiceListJobsFiltersError
115117

116118
job_parent_resource_name_prefix = compose_resource_name(
117119
*collection_or_resource_ids

services/api-server/src/simcore_service_api_server/exceptions/custom_errors.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,7 @@ class MissingWalletError(CustomBaseError):
1616

1717
class ApplicationSetupError(CustomBaseError):
1818
pass
19+
20+
21+
class SolverServiceListJobsFiltersError(CustomBaseError, ValueError):
22+
msg_template = "solver_version is set but solver_id is not. Please provide both or none of them"

0 commit comments

Comments
 (0)