Skip to content

Commit ec42045

Browse files
committed
✨ Integrate setup_login_auth in login plugin and remove unnecessary setup_products call in security plugin
1 parent eee5848 commit ec42045

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

services/web/server/src/simcore_service_webserver/login/plugin.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
from ..email.plugin import setup_email
1919
from ..email.settings import get_plugin_settings as get_email_plugin_settings
2020
from ..invitations.plugin import setup_invitations
21+
from ..login_auth.plugin import setup_login_auth
2122
from ..products import products_service
2223
from ..products.models import ProductName
2324
from ..products.plugin import setup_products
@@ -147,6 +148,7 @@ def setup_login(app: web.Application):
147148

148149
_setup_login_options(app)
149150
setup_login_storage(app)
151+
setup_login_auth(app)
150152

151153
app.on_startup.append(_resolve_login_settings_per_product)
152154

services/web/server/src/simcore_service_webserver/login_auth/plugin.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
__name__, ModuleCategory.ADDON, settings_name="WEBSERVER_LOGIN_AUTH", logger=_logger
1616
)
1717
def setup_login_auth(app: web.Application):
18-
1918
setup_products(app)
2019
setup_security(app)
2120
setup_rest(app)

services/web/server/src/simcore_service_webserver/security/plugin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
__name__, ModuleCategory.SYSTEM, settings_name="WEBSERVER_SECURITY", logger=_logger
2828
)
2929
def setup_security(app: web.Application):
30-
30+
# NOTE: no need for setup_products
3131
setup_session(app)
3232
setup_db(app)
3333

0 commit comments

Comments
 (0)