Skip to content

Commit ed0f7ac

Browse files
committed
not a service by a web
1 parent e455535 commit ed0f7ac

File tree

19 files changed

+54
-48
lines changed

19 files changed

+54
-48
lines changed

packages/pytest-simcore/src/pytest_simcore/helpers/webserver_login.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
get_plugin_storage,
1818
)
1919
from simcore_service_webserver.products.products_service import list_products
20-
from simcore_service_webserver.security.security_service import clean_auth_policy_cache
20+
from simcore_service_webserver.security import security_web
2121
from yarl import URL
2222

2323
from .assert_checks import assert_status
@@ -187,7 +187,7 @@ async def __aexit__(self, *args):
187187
assert self.client.app
188188
# NOTE: cache key is based on an email. If the email is
189189
# reused during the test, then it creates quite some noise
190-
await clean_auth_policy_cache(self.client.app)
190+
await security_web.clean_auth_policy_cache(self.client.app)
191191
return await super().__aexit__(*args)
192192

193193

services/web/server/src/simcore_service_webserver/garbage_collector/_tasks_users.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from tenacity.wait import wait_exponential
1616

1717
from ..login import login_service
18-
from ..security import security_service
18+
from ..security import security_web
1919
from ..users.api import update_expired_users
2020

2121
_logger = logging.getLogger(__name__)
@@ -62,7 +62,7 @@ async def _update_expired_users(app: web.Application):
6262
if updated := await update_expired_users(app):
6363
# expired users might be cached in the auth. If so, any request
6464
# with this user-id will get thru producing unexpected side-effects
65-
await security_service.clean_auth_policy_cache(app)
65+
await security_web.clean_auth_policy_cache(app)
6666

6767
# broadcast force logout of user_id
6868
for user_id in updated:

services/web/server/src/simcore_service_webserver/login/_auth_service.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
from ..groups import api as groups_service
1212
from ..products.models import Product
13-
from ..security import security_service
13+
from ..security import security_web
1414
from . import _login_service
1515
from ._constants import MSG_UNKNOWN_EMAIL, MSG_WRONG_PASSWORD
1616
from ._login_repository_legacy import AsyncpgStorage, get_plugin_storage
@@ -35,7 +35,7 @@ async def create_user(
3535
user = await UsersRepo.new_user(
3636
conn,
3737
email=email,
38-
password_hash=security_service.encrypt_password(password),
38+
password_hash=security_web.encrypt_password(password),
3939
status=status_upon_creation,
4040
expires_at=expires_at,
4141
)
@@ -58,7 +58,7 @@ async def check_authorized_user_credentials_or_raise(
5858

5959
_login_service.validate_user_status(user=user, support_email=product.support_email)
6060

61-
if not security_service.check_password(password, user["password_hash"]):
61+
if not security_web.check_password(password, user["password_hash"]):
6262
raise web.HTTPUnauthorized(
6363
reason=MSG_WRONG_PASSWORD, content_type=MIMETYPE_APPLICATION_JSON
6464
)

services/web/server/src/simcore_service_webserver/login/_controller/rest/auth.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from ...._meta import API_VTAG
1616
from ....products import products_web
1717
from ....products.models import Product
18-
from ....security import security_service
18+
from ....security import security_web
1919
from ....session.access_policies import (
2020
on_success_grant_session_access_to,
2121
session_access_required,
@@ -284,7 +284,7 @@ async def logout(request: web.Request) -> web.Response:
284284
await _login_service.notify_user_logout(
285285
request.app, user_id, logout_.client_session_id
286286
)
287-
await security_service.forget_identity(request, response)
287+
await security_web.forget_identity(request, response)
288288

289289
return response
290290

services/web/server/src/simcore_service_webserver/login/_controller/rest/change.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from ...._meta import API_VTAG
1616
from ....products import products_web
1717
from ....products.models import Product
18-
from ....security import security_service
18+
from ....security import security_web
1919
from ....users import api as users_service
2020
from ....utils import HOUR
2121
from ....utils_rate_limiting import global_rate_limit_route
@@ -293,7 +293,7 @@ async def change_password(request: web.Request):
293293
user = await db.get_user({"id": request[RQT_USERID_KEY]})
294294
assert user # nosec
295295

296-
if not security_service.check_password(
296+
if not security_web.check_password(
297297
passwords.current.get_secret_value(), user["password_hash"]
298298
):
299299
raise web.HTTPUnprocessableEntity(
@@ -303,7 +303,7 @@ async def change_password(request: web.Request):
303303
await db.update_user(
304304
dict(user),
305305
{
306-
"password_hash": security_service.encrypt_password(
306+
"password_hash": security_web.encrypt_password(
307307
passwords.new.get_secret_value()
308308
)
309309
},

services/web/server/src/simcore_service_webserver/login/_controller/rest/confirmation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
from ....products import products_web
3030
from ....products.models import Product
31-
from ....security import security_service
31+
from ....security import security_web
3232
from ....session.access_policies import session_access_required
3333
from ....utils import HOUR, MINUTE
3434
from ....utils_aiohttp import create_redirect_to_page_response
@@ -302,7 +302,7 @@ async def complete_reset_password(request: web.Request):
302302
await db.update_user(
303303
user={"id": user["id"]},
304304
updates={
305-
"password_hash": security_service.encrypt_password(
305+
"password_hash": security_web.encrypt_password(
306306
request_body.password.get_secret_value()
307307
)
308308
},

services/web/server/src/simcore_service_webserver/login/_controller/rest/preregistration.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from ....constants import RQ_PRODUCT_KEY
2121
from ....products import products_web
2222
from ....products.models import Product
23-
from ....security import security_service
23+
from ....security import security_web
2424
from ....security.decorators import permission_required
2525
from ....session.api import get_session
2626
from ....users.api import get_user_credentials, set_user_as_deleted
@@ -109,7 +109,7 @@ async def unregister_account(request: web.Request):
109109

110110
# checks before deleting
111111
credentials = await get_user_credentials(request.app, user_id=req_ctx.user_id)
112-
if body.email != credentials.email.lower() or not security_service.check_password(
112+
if body.email != credentials.email.lower() or not security_web.check_password(
113113
body.password.get_secret_value(), credentials.password_hash
114114
):
115115
raise web.HTTPConflict(
@@ -131,7 +131,7 @@ async def unregister_account(request: web.Request):
131131
request.app, user_id=req_ctx.user_id, client_session_id=None
132132
)
133133
response = flash_response(MSG_LOGGED_OUT, "INFO")
134-
await security_service.forget_identity(request, response)
134+
await security_web.forget_identity(request, response)
135135

136136
# send email in the background
137137
fire_and_forget_task(

services/web/server/src/simcore_service_webserver/login/_security_service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from aiohttp import web
77
from servicelib.logging_utils import get_log_record_extra, log_context
88

9-
from ..security import security_service
9+
from ..security import security_web
1010
from ._constants import MSG_LOGGED_IN
1111
from ._login_service import flash_response
1212

@@ -36,7 +36,7 @@ async def login_granted_response(
3636
extra=get_log_record_extra(user_id=user_id),
3737
):
3838
response = flash_response(MSG_LOGGED_IN, "INFO")
39-
return await security_service.remember_identity(
39+
return await security_web.remember_identity(
4040
request=request,
4141
response=response,
4242
user_email=email,

services/web/server/src/simcore_service_webserver/login/decorators.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from servicelib.request_keys import RQT_USERID_KEY
99

1010
from ..products import products_web
11-
from ..security import security_service
11+
from ..security import security_web
1212

1313

1414
def login_required(handler: HandlerAnyReturn) -> HandlerAnyReturn:
@@ -51,13 +51,13 @@ async def _wrapper(request: web.Request):
5151
"""
5252
# WARNING: note that check_authorized is patched in some tests.
5353
# Careful when changing the function signature
54-
user_id = await security_service.check_user_authorized(request)
54+
user_id = await security_web.check_user_authorized(request)
5555
product_name = products_web.get_product_name(request)
5656

57-
await security_service.check_user_permission(
57+
await security_web.check_user_permission(
5858
request,
59-
security_service.PERMISSION_PRODUCT_LOGIN_KEY,
60-
context=security_service.AuthContextDict(
59+
security_web.PERMISSION_PRODUCT_LOGIN_KEY,
60+
context=security_web.AuthContextDict(
6161
product_name=product_name,
6262
authorized_uid=user_id,
6363
),

services/web/server/src/simcore_service_webserver/projects/_controller/projects_rest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
from ...login.decorators import login_required
3333
from ...redis import get_redis_lock_manager_client_sdk
3434
from ...resource_manager.user_sessions import PROJECT_ID_KEY, managed_resource
35-
from ...security import security_service
35+
from ...security import security_web
3636
from ...security.decorators import permission_required
3737
from ...users.api import get_user_fullname
3838
from ...utils_aiohttp import envelope_json_response, get_api_base_url
@@ -76,7 +76,7 @@ async def create_project(request: web.Request):
7676
)
7777
header_params = parse_request_headers_as(ProjectCreateHeaders, request)
7878
if query_params.as_template: # create template from
79-
await security_service.check_user_permission(request, "project.template.create")
79+
await security_web.check_user_permission(request, "project.template.create")
8080

8181
# NOTE: Having so many different types of bodys is an indication that
8282
# this entrypoint are in reality multiple entrypoints in one, namely

0 commit comments

Comments
 (0)