♻️ Refactor HTTP error handler to improve logging and response structure

Author: pcrespov

packages/service-library/src/servicelib/fastapi/http_error.py

@@ -48,24 +48,35 @@ async def _http_error_handler(request: Request, exc: Exception) -> JSONResponse:
             "errors": error_extractor(exc) if error_extractor else [f"{exc}"]
         }
 
+        response = JSONResponse(
+            content=jsonable_encoder(
+                {"error": error_content} if envelope_error else error_content
+            ),
+            status_code=status_code,
+        )
+
         if is_5xx_server_error(status_code):
             _logger.exception(
                 create_troubleshootting_log_kwargs(
-                    "Unexpected error happened in the Resource Usage Tracker. Please contact support.",
+                    f"A 5XX server error happened in current service. Responding with {error_content} and {status_code} status code",
                     error=exc,
                     error_context={
                         "request": request,
-                        "request.method": f"{request.method}",
+                        "request.client_host": (
+                            request.client.host if request.client else "unknown"
+                        ),
+                        "request.method": request.method,
+                        "request.url_path": request.url.path,
+                        "request.query_params": dict(request.query_params),
+                        "request.headers": dict(request.headers),
+                        "response": response,
+                        "response.error_content": error_content,
+                        "response.status_code": status_code,
                     },
                 )
             )
 
-        return JSONResponse(
-            content=jsonable_encoder(
-                {"error": error_content} if envelope_error else error_content
-            ),
-            status_code=status_code,
-        )
+        return response
 
     return _http_error_handler