fix

Author: giancarloromeo

services/storage/src/simcore_service_storage/modules/celery/tasks.py

@@ -3,7 +3,6 @@
 
 
 from celery import Task
-from common_library.errors_classes import OsparcErrorMixin
 from models_library.progress_bar import ProgressReport
 from models_library.projects_nodes_io import StorageFileID
 from servicelib.logging_utils import log_context
@@ -29,12 +28,3 @@ def export_data(task: Task, files: list[StorageFileID]):
             )
             time.sleep(10)
     return "done"
-
-
-class MyError(OsparcErrorMixin, Exception):
-   msg_template = "Something strange happened: {msg}"
-
-
-def export_data_with_error(task: Task, files: list[StorageFileID]):
-    msg = "BOOM!"
-    raise MyError(msg=msg)

services/storage/src/simcore_service_storage/modules/celery/worker_main.py

@@ -11,7 +11,7 @@
 
 from ...core.settings import ApplicationSettings
 from ._common import create_app as create_celery_app, define_task
-from .tasks import export_data, export_data_with_error
+from .tasks import export_data
 
 _settings = ApplicationSettings.create_from_envs()
 
@@ -31,4 +31,3 @@
 worker_shutdown.connect(on_worker_shutdown)
 
 define_task(app, export_data)
-define_task(app, export_data_with_error)

services/storage/tests/unit/modules/celery/test_celery.py

@@ -8,6 +8,7 @@
 import pytest
 from celery import Celery, Task
 from celery.contrib.abortable import AbortableTask
+from common_library.errors_classes import OsparcErrorMixin
 from models_library.progress_bar import ProgressReport
 from servicelib.logging_utils import log_context
 from simcore_service_storage.modules.celery import get_event_loop
@@ -52,9 +53,13 @@ def sync_archive(task: Task, files: list[str]) -> str:
     ).result()
 
 
-def failure_task(task: Task) -> str:
-    msg = "my error here"
-    raise ValueError(msg)
+class MyError(OsparcErrorMixin, Exception):
+   msg_template = "Something strange happened: {msg}"
+
+
+def failure_task(task: Task):
+    msg = "BOOM!"
+    raise MyError(msg=msg)
 
 
 def dreamer_task(task: AbortableTask) -> list[int]:
@@ -130,7 +135,7 @@ async def test_submitting_task_with_failure_results_with_error(
     ).task_state == TaskState.ERROR
     raw_result = await celery_client.get_task_result(task_context, task_uuid)
     result = TypeAdapter(TaskError).validate_python(raw_result)
-    assert f"{result.exc_msg}" == "my error here"
+    assert f"{result.exc_msg}" == "Something strange happened: BOOM!"
 
 
 @pytest.mark.usefixtures("celery_worker")