Skip to content

Commit edbd1c6

Browse files
continue fixing
1 parent 75ac5c8 commit edbd1c6

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

services/director-v2/src/simcore_service_director_v2/api/errors/http_error.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ async def http_error_handler(_: Request, exc: HTTPException) -> JSONResponse:
1414

1515
def make_http_error_handler_for_exception(
1616
status_code: int, exception_cls: type[BaseException]
17-
) -> Callable[[Request, type[BaseException]], Awaitable[JSONResponse]]:
17+
) -> Callable[[Request, Exception], Awaitable[JSONResponse]]:
1818
"""
1919
Produces a handler for BaseException-type exceptions which converts them
2020
into an error JSON response with a given status code

services/director-v2/src/simcore_service_director_v2/models/comp_tasks.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,8 @@ def to_db_model(self, **exclusion_rules) -> dict[str, Any]:
230230
"state": "NOT_STARTED",
231231
"progress": 0.44,
232232
"last_heartbeat": None,
233-
"created": "2022-05-20 13:28:31.139+00",
234-
"modified": "2023-06-23 15:58:32.833081+00",
233+
"created": "2022-05-20T13:28:31.139",
234+
"modified": "2023-06-23T15:58:32.83308",
235235
"pricing_info": {
236236
"pricing_plan_id": 1,
237237
"pricing_unit_id": 1,

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/api_client/_public.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ def _get_client(self, dynamic_sidecar_endpoint: AnyHttpUrl) -> Client:
293293
return Client(
294294
app=self._app,
295295
async_client=self._async_client,
296-
base_url=dynamic_sidecar_endpoint,
296+
base_url=f"{dynamic_sidecar_endpoint}",
297297
)
298298

299299
async def _await_for_result(

services/director-v2/tests/unit/test_utils_distributed_identifier.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from uuid import UUID, uuid4
1111

1212
import pytest
13-
from pydantic import BaseModel, NonNegativeInt, StrBytes
13+
from pydantic import BaseModel, NonNegativeInt
1414
from pytest_mock import MockerFixture
1515
from servicelib.redis import RedisClientSDK
1616
from servicelib.utils import logged_gather
@@ -132,8 +132,8 @@ def _serialize_identifier(cls, identifier: UserDefinedID) -> str:
132132
return f"{identifier._id}" # noqa: SLF001
133133

134134
@classmethod
135-
def _deserialize_cleanup_context(cls, raw: StrBytes) -> AnEmptyTextCleanupContext:
136-
return AnEmptyTextCleanupContext.parse_raw(raw)
135+
def _deserialize_cleanup_context(cls, raw: str | bytes) -> AnEmptyTextCleanupContext:
136+
return AnEmptyTextCleanupContext.model_validate_json(raw)
137137

138138
@classmethod
139139
def _serialize_cleanup_context(

services/director-v2/tests/unit/with_dbs/test_api_route_computations_tasks.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from uuid import uuid4
1010

1111
import httpx
12+
from pydantic import TypeAdapter
1213
import pytest
1314
from faker import Faker
1415
from fastapi import FastAPI, status
@@ -21,7 +22,6 @@
2122
from models_library.projects import ProjectAtDB, ProjectID
2223
from models_library.projects_nodes_io import NodeID
2324
from models_library.users import UserID
24-
from pydantic import parse_raw_as
2525
from pytest_simcore.helpers.monkeypatch_envs import setenvs_from_dict
2626
from pytest_simcore.helpers.typing_env import EnvVarsDict
2727
from simcore_service_director_v2.core.settings import AppSettings
@@ -162,7 +162,7 @@ async def test_get_all_tasks_log_files(
162162

163163
# test expected response according to OAS!
164164
assert resp.status_code == status.HTTP_200_OK
165-
log_files = parse_raw_as(list[TaskLogFileGet], resp.text)
165+
log_files = TypeAdapter(list[TaskLogFileGet]).validate_json(resp.text)
166166
assert log_files
167167
assert all(l.download_link for l in log_files)
168168

services/director-v2/tests/unit/with_dbs/test_modules_comp_scheduler_dask_scheduler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
RabbitResourceTrackingStoppedMessage,
4242
)
4343
from models_library.users import UserID
44-
from pydantic import TypeAdapter, parse_raw_as
44+
from pydantic import TypeAdapter
4545
from pytest_mock.plugin import MockerFixture
4646
from pytest_simcore.helpers.typing_env import EnvVarsDict
4747
from servicelib.rabbitmq import RabbitMQClient
@@ -732,7 +732,7 @@ async def _return_1st_task_running(job_ids: list[str]) -> list[DaskClientTaskSta
732732
assert messages[0].service_uuid == exp_started_task.node_id
733733

734734
def _parser(x) -> RabbitResourceTrackingMessages:
735-
return parse_raw_as(RabbitResourceTrackingMessages, x)
735+
return TypeAdapter(RabbitResourceTrackingMessages).validate_json(x)
736736

737737
messages = await _assert_message_received(
738738
resource_tracking_rabbit_client_parser,

0 commit comments

Comments
 (0)