Skip to content

Commit edea03d

Browse files
author
Andrei Neagu
committed
fixed tests
1 parent aa03848 commit edea03d

File tree

2 files changed

+20
-10
lines changed

2 files changed

+20
-10
lines changed

packages/service-library/tests/fastapi/long_running_tasks/test_long_running_tasks.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@
1919
from fastapi import APIRouter, Depends, FastAPI, status
2020
from httpx import AsyncClient
2121
from pydantic import TypeAdapter
22+
from servicelib.fastapi.long_running_tasks._manager import FastAPILongRunningManager
2223
from servicelib.fastapi.long_running_tasks.client import setup as setup_client
2324
from servicelib.fastapi.long_running_tasks.server import (
24-
get_tasks_manager,
25+
get_long_running_manager,
2526
)
2627
from servicelib.fastapi.long_running_tasks.server import setup as setup_server
2728
from servicelib.long_running_tasks.models import (
@@ -30,7 +31,7 @@
3031
TaskProgress,
3132
TaskStatus,
3233
)
33-
from servicelib.long_running_tasks.task import TaskContext, TasksManager, start_task
34+
from servicelib.long_running_tasks.task import TaskContext, start_task
3435
from tenacity.asyncio import AsyncRetrying
3536
from tenacity.retry import retry_if_exception_type
3637
from tenacity.stop import stop_after_delay
@@ -69,10 +70,12 @@ async def create_string_list_task(
6970
num_strings: int,
7071
sleep_time: float,
7172
fail: bool = False,
72-
task_manager: TasksManager = Depends(get_tasks_manager),
73+
long_running_manager: FastAPILongRunningManager = Depends(
74+
get_long_running_manager
75+
),
7376
) -> TaskId:
7477
task_id = start_task(
75-
task_manager,
78+
long_running_manager.tasks_manager,
7679
_string_list_task,
7780
num_strings=num_strings,
7881
sleep_time=sleep_time,

packages/service-library/tests/fastapi/long_running_tasks/test_long_running_tasks_context_manager.py

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
from httpx import AsyncClient
1212
from pydantic import AnyHttpUrl, PositiveFloat, TypeAdapter
1313
from servicelib.fastapi.long_running_tasks._context_manager import _ProgressManager
14+
from servicelib.fastapi.long_running_tasks._manager import FastAPILongRunningManager
1415
from servicelib.fastapi.long_running_tasks.client import Client, periodic_task_result
1516
from servicelib.fastapi.long_running_tasks.client import setup as setup_client
16-
from servicelib.fastapi.long_running_tasks.server import get_tasks_manager
17+
from servicelib.fastapi.long_running_tasks.server import get_long_running_manager
1718
from servicelib.fastapi.long_running_tasks.server import setup as setup_server
1819
from servicelib.long_running_tasks.errors import (
1920
TaskClientTimeoutError,
@@ -24,7 +25,7 @@
2425
TaskId,
2526
TaskProgress,
2627
)
27-
from servicelib.long_running_tasks.task import TasksManager, start_task
28+
from servicelib.long_running_tasks.task import start_task
2829

2930
TASK_SLEEP_INTERVAL: Final[PositiveFloat] = 0.1
3031

@@ -55,16 +56,22 @@ def user_routes() -> APIRouter:
5556

5657
@router.get("/api/success", status_code=status.HTTP_200_OK)
5758
async def create_task_user_defined_route(
58-
tasks_manager: TasksManager = Depends(get_tasks_manager),
59+
long_running_manager: FastAPILongRunningManager = Depends(
60+
get_long_running_manager
61+
),
5962
) -> TaskId:
60-
task_id = start_task(tasks_manager, task=a_test_task)
63+
task_id = start_task(long_running_manager.tasks_manager, task=a_test_task)
6164
return task_id
6265

6366
@router.get("/api/failing", status_code=status.HTTP_200_OK)
6467
async def create_task_which_fails(
65-
task_manager: TasksManager = Depends(get_tasks_manager),
68+
long_running_manager: FastAPILongRunningManager = Depends(
69+
get_long_running_manager
70+
),
6671
) -> TaskId:
67-
task_id = start_task(task_manager, task=a_failing_test_task)
72+
task_id = start_task(
73+
long_running_manager.tasks_manager, task=a_failing_test_task
74+
)
6875
return task_id
6976

7077
return router

0 commit comments

Comments
 (0)