Skip to content

Commit ee52317

Browse files
fix: shutdown
1 parent 41446dc commit ee52317

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

packages/celery-library/tests/conftest.py

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import datetime
55
import logging
66
import threading
7-
from asyncio import wait_for
87
from collections.abc import AsyncIterator, Callable
98
from functools import partial
109
from typing import Any
@@ -15,14 +14,13 @@
1514
from celery.signals import worker_init
1615
from celery.worker.worker import WorkController
1716
from celery_library.backends._redis import RedisTaskInfoStore
18-
from celery_library.signals import on_worker_init, on_worker_shutdown
17+
from celery_library.signals import on_worker_init
1918
from celery_library.task_manager import CeleryTaskManager
2019
from celery_library.types import register_celery_types
2120
from pytest_simcore.helpers.monkeypatch_envs import setenvs_from_dict
2221
from pytest_simcore.helpers.typing_env import EnvVarsDict
2322
from servicelib.celery.app_server import BaseAppServer
2423
from servicelib.celery.task_manager import TaskManager
25-
from servicelib.logging_utils import log_catch
2624
from servicelib.redis import RedisClientSDK
2725
from settings_library.celery import CelerySettings
2826
from settings_library.redis import RedisDatabase, RedisSettings
@@ -70,8 +68,7 @@ async def start_and_hold(self, startup_completed_event: threading.Event) -> None
7068
startup_completed_event.set()
7169
await self.shutdown_event.wait() # wait for shutdown
7270

73-
with log_catch(_logger, reraise=False):
74-
await wait_for(redis_client_sdk.shutdown(), timeout=5.0)
71+
await redis_client_sdk.shutdown()
7572

7673

7774
@pytest.fixture
@@ -145,11 +142,7 @@ def _on_worker_init_wrapper(sender: WorkController, **_kwargs):
145142
perform_ping_check=False,
146143
queues="default",
147144
) as worker:
148-
try:
149-
yield worker
150-
finally:
151-
worker.stop() # explicitly stop the worker
152-
on_worker_shutdown(worker)
145+
yield worker
153146

154147

155148
@pytest.fixture
@@ -174,5 +167,4 @@ async def celery_task_manager(
174167
RedisTaskInfoStore(redis_client_sdk),
175168
)
176169
finally:
177-
with log_catch(_logger, reraise=False):
178-
await wait_for(redis_client_sdk.shutdown(), timeout=5.0)
170+
await redis_client_sdk.shutdown()

0 commit comments

Comments
 (0)