improve

Author: matusdrobuliak66

packages/postgres-database/src/simcore_postgres_database/utils_comp_runs.py

@@ -1,3 +1,4 @@
+import logging
 from typing import cast
 
 import sqlalchemy as sa
@@ -7,13 +8,15 @@
 from .models.comp_runs import comp_runs
 from .utils_repos import pass_or_acquire_connection
 
+_logger = logging.getLogger(__name__)
+
 
 async def get_latest_run_id_for_project(
     engine: AsyncEngine,
     conn: AsyncConnection | None = None,
     *,
     project_id: str,
-) -> PositiveInt:
+) -> PositiveInt | None:
     # Get latest run per (project_uuid, user_id)
     project_and_user_latest_runs = (
         sa.select(
@@ -68,6 +71,7 @@ async def get_latest_run_id_for_project(
         result = await _conn.execute(base_select_query)
         row = result.one_or_none()
         if not row:
-            msg = f"get_latest_run_id_for_project did not return any row for project_id={project_id}"
-            raise ValueError(msg)
+            msg = f"get_latest_run_id_for_project did not return any row for project_id={project_id} (MD: I think this should not happen, but if it happens contact MD/SAN)"
+            _logger.error(msg)
+            return None
         return cast(PositiveInt, row.run_id)

packages/simcore-sdk/src/simcore_sdk/node_ports_common/dbmanager.py

@@ -66,18 +66,19 @@ async def _update_comp_run_snapshot_tasks_if_computational(
         _latest_run_id = await get_latest_run_id_for_project(
             engine, connection, project_id=project_id
         )
-        await update_for_run_id_and_node_id(
-            engine,
-            connection,
-            run_id=_latest_run_id,
-            node_id=node_uuid,
-            data={
-                "schema": node_configuration["schema"],
-                "inputs": node_configuration["inputs"],
-                "outputs": node_configuration["outputs"],
-                "run_hash": node_configuration.get("run_hash"),
-            },
-        )
+        if _latest_run_id is not None:
+            await update_for_run_id_and_node_id(
+                engine,
+                connection,
+                run_id=_latest_run_id,
+                node_id=node_uuid,
+                data={
+                    "schema": node_configuration["schema"],
+                    "inputs": node_configuration["inputs"],
+                    "outputs": node_configuration["outputs"],
+                    "run_hash": node_configuration.get("run_hash"),
+                },
+            )
 
 
 class DBContextManager: