Skip to content

Commit f23a597

Browse files
GitHKAndrei Neagu
andauthored
🐛 Fix flaky test_disk_usage (#5364)
Co-authored-by: Andrei Neagu <[email protected]>
1 parent 889e0ff commit f23a597

File tree

1 file changed

+22
-3
lines changed

1 file changed

+22
-3
lines changed
Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,29 @@
11
import psutil
2+
import pytest
23
from models_library.api_schemas_dynamic_sidecar.telemetry import DiskUsage
4+
from psutil._common import sdiskusage
35

46

5-
def test_disk_usage():
6-
ps_util_disk_usage = psutil.disk_usage("/")
7+
def _assert_same_value(ps_util_disk_usage: sdiskusage) -> None:
78
disk_usage = DiskUsage.from_ps_util_disk_usage(ps_util_disk_usage)
89
assert disk_usage.used == ps_util_disk_usage.used
910
assert disk_usage.free == ps_util_disk_usage.free
10-
assert round(disk_usage.used_percent, 1) == round(ps_util_disk_usage.percent, 1)
11+
assert disk_usage.used_percent == pytest.approx(ps_util_disk_usage.percent, abs=1e3)
12+
13+
14+
@pytest.mark.parametrize(
15+
"ps_util_disk_usage",
16+
[
17+
sdiskusage(total=77851254784, used=58336940032, free=19497537536, percent=74.9),
18+
sdiskusage(total=77851254784, used=58573619200, free=19260858368, percent=75.3),
19+
sdiskusage(total=77851254784, used=58573529088, free=19260948480, percent=75.3),
20+
sdiskusage(total=77851254784, used=58573664256, free=19260813312, percent=75.3),
21+
],
22+
)
23+
def test_disk_usage_regression_cases(ps_util_disk_usage: sdiskusage):
24+
_assert_same_value(ps_util_disk_usage)
25+
26+
27+
def test_disk_usage():
28+
ps_util_disk_usage = psutil.disk_usage("/")
29+
_assert_same_value(ps_util_disk_usage)

0 commit comments

Comments
 (0)