fixes http response headers

Author: pcrespov

services/web/server/src/simcore_service_webserver/activity/_handlers.py

@@ -6,6 +6,7 @@
 from models_library.api_schemas_webserver.activity import ActivityStatusDict
 from pydantic import TypeAdapter
 from servicelib.aiohttp.client_session import get_client_session
+from servicelib.mimetype_constants import MIMETYPE_APPLICATION_JSON
 from servicelib.request_keys import RQT_USERID_KEY
 from yarl import URL
 

services/web/server/src/simcore_service_webserver/exception_handling/_factory.py

@@ -5,10 +5,11 @@
 from common_library.error_codes import create_error_code
 from common_library.json_serialization import json_dumps
 from models_library.rest_error import ErrorGet
+from servicelib.aiohttp.rest_responses import safe_status_message
 from servicelib.aiohttp.web_exceptions_extension import get_all_aiohttp_http_exceptions
 from servicelib.logging_errors import create_troubleshootting_log_kwargs
 from servicelib.status_codes_utils import (
-    get_code_description,
+    get_code_display_name,
     is_5xx_server_error,
     is_error,
 )
@@ -53,7 +54,7 @@ def create_error_response(error: ErrorGet, status_code: int) -> web.Response:
     return web.json_response(
         data={"error": error.model_dump(exclude_unset=True, mode="json")},
         dumps=json_dumps,
-        reason=get_code_description(status_code),
+        reason=safe_status_message(get_code_display_name(status_code)),
         status=status_code,
     )
 

services/web/server/tests/unit/isolated/test_exception_handling_factory.py

@@ -13,6 +13,7 @@
 from aiohttp.test_utils import make_mocked_request
 from servicelib.aiohttp import status
 from servicelib.mimetype_constants import MIMETYPE_APPLICATION_JSON
+from servicelib.status_codes_utils import get_code_display_name
 from simcore_service_webserver.errors import WebServerBaseError
 from simcore_service_webserver.exception_handling._base import (
     ExceptionHandlingContextManager,
@@ -28,16 +29,13 @@
 # Some custom errors in my service
 
 
-class BaseError(WebServerBaseError):
-    ...
+class BaseError(WebServerBaseError): ...
 
 
-class OneError(BaseError):
-    ...
+class OneError(BaseError): ...
 
 
-class OtherError(BaseError):
-    ...
+class OtherError(BaseError): ...
 
 
 @pytest.fixture
@@ -58,7 +56,7 @@ async def test_factory__create_exception_handler_from_http_error(
     response = await one_error_to_404(fake_request, caught)
     assert response.status == status.HTTP_404_NOT_FOUND
     assert response.text is not None
-    assert "one error message" in response.reason
+    assert response.reason == get_code_display_name(response.status)
     assert response.content_type == MIMETYPE_APPLICATION_JSON
 
 
@@ -82,9 +80,7 @@ async def test_handling_different_exceptions_with_context(
         response = cm.get_response_or_none()
         assert response is not None
         assert response.status == status.HTTP_400_BAD_REQUEST
-        assert response.reason == exc_to_http_error_map[OneError].msg_template.format(
-            code="WebServerBaseError.BaseError.OneError"
-        )
+        assert response.reason == get_code_display_name(response.status)
         assert not caplog.records
 
         # unhandled -> reraises
@@ -103,9 +99,7 @@ async def test_handling_different_exceptions_with_context(
         response = cm.get_response_or_none()
         assert response is not None
         assert response.status == status.HTTP_500_INTERNAL_SERVER_ERROR
-        assert response.reason == exc_to_http_error_map[OtherError].msg_template.format(
-            code="WebServerBaseError.BaseError.OtherError"
-        )
+        assert response.reason == get_code_display_name(response.status)
         assert caplog.records, "Expected 5XX troubleshooting logged as error"
         assert caplog.records[0].levelno == logging.ERROR