@sanderegg review: relative imports and casting

Author: pcrespov

services/catalog/src/simcore_service_catalog/api/rest/_services_access_rights.py

@@ -8,7 +8,6 @@
 from models_library.services import ServiceKey, ServiceVersion
 
 from ..._constants import RESPONSE_MODEL_POLICY
-from ...models.services_db import ServiceAccessRightsAtDB
 from ...repository.services import ServicesRepository
 from .._dependencies.repository import get_repository
 from .._dependencies.services import AccessInfo, check_service_read_access
@@ -33,12 +32,10 @@ async def get_service_access_rights(
     ],
     x_simcore_products_name: Annotated[str, Header(...)],
 ):
-    service_access_rights: list[ServiceAccessRightsAtDB] = (
-        await services_repo.get_service_access_rights(
-            key=service_key,
-            version=service_version,
-            product_name=x_simcore_products_name,
-        )
+    service_access_rights = await services_repo.get_service_access_rights(
+        key=service_key,
+        version=service_version,
+        product_name=x_simcore_products_name,
     )
 
     gids_with_access_rights = {}

services/catalog/src/simcore_service_catalog/core/background_tasks.py

@@ -22,16 +22,15 @@
 from models_library.services_types import ServiceKey, ServiceVersion
 from packaging.version import Version
 from pydantic import ValidationError
-from simcore_service_catalog.api._dependencies.director import get_director_client
-from simcore_service_catalog.service import manifest
 from sqlalchemy.exc import SQLAlchemyError
 from sqlalchemy.ext.asyncio import AsyncEngine
 
+from ..api._dependencies.director import get_director_client
 from ..models.services_db import ServiceAccessRightsAtDB, ServiceMetaDataDBCreate
 from ..repository.groups import GroupsRepository
 from ..repository.projects import ProjectsRepository
 from ..repository.services import ServicesRepository
-from ..service import access_rights
+from ..service import access_rights, manifest
 
 _logger = logging.getLogger(__name__)
 

services/catalog/src/simcore_service_catalog/service/services.py

@@ -22,14 +22,14 @@
     CatalogForbiddenError,
     CatalogItemNotFoundError,
 )
-from simcore_service_catalog.repository.groups import GroupsRepository
 
 from ..clients.director import DirectorClient
 from ..models.services_db import (
     ServiceAccessRightsAtDB,
     ServiceMetaDataDBPatch,
     ServiceWithHistoryDBGet,
 )
+from ..repository.groups import GroupsRepository
 from ..repository.services import ServicesRepository
 from . import manifest
 from .compatibility import evaluate_service_compatibility_map