Skip to content

Commit f3bcb28

Browse files
committed
handle exceptions in aiohttp response
1 parent 1f73bf7 commit f3bcb28

File tree

1 file changed

+8
-4
lines changed
  • packages/service-library/src/servicelib/aiohttp

1 file changed

+8
-4
lines changed

packages/service-library/src/servicelib/aiohttp/tracing.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,14 @@ def _startup(
152152

153153
@web.middleware
154154
async def ResponseTraceIdHeaderMiddleware(request: web.Request, handler):
155-
response = await handler(request)
156-
trace_id_header = get_trace_id_header()
157-
if trace_id_header:
158-
response.headers.update(trace_id_header)
155+
try:
156+
response = await handler(request)
157+
except web.HTTPException as exc:
158+
if headers := get_trace_id_header():
159+
exc.headers.update(headers)
160+
raise exc
161+
if headers := get_trace_id_header():
162+
response.headers.update(headers)
159163
return response
160164

161165

0 commit comments

Comments
 (0)