Minor fix catalog exception exception and doc (#1829)

* Minor fix

* Cleanup doc

* improves msg

Author: pcrespov

docs/releasing-workflow-instructions.md

@@ -4,46 +4,46 @@ The process of creating staging/release/hotfix versions of code from [Master](ht
 
 ## Description
 
-Each commit on the master branch triggers a CI workflow that builds the simcore platform docker images.
-These docker images are then stored on [dockerhub](https://hub.docker.com/repositories/itisfoundation) registry in the itisfoundation repository.
-Each docker image are named following this pattern:
+Each commit on the *master* branch triggers a CI workflow that builds the simcore platform docker images.
+These docker images are then stored on [dockerhub](https://hub.docker.com/repositories/itisfoundation) registry in the itisfoundation [repository](https://hub.docker.com/repositories/itisfoundation).
+Each docker image are named with the following pattern:
 
-- itisfoundation/[image_name]:master-[CINAME]-latest
-- itisfoundation/[image_name]:master-[CINAME]-[BUILD_DATE]--[BUILD_TIME].[GIT_SHA]
+- ``itisfoundation/[image_name]:master-[CINAME]-latest``
+- ``itisfoundation/[image_name]:master-[CINAME]-[BUILD_DATE]--[BUILD_TIME].[GIT_SHA]``
 
 with:
 
-- CINAME the name of the CI
-- BUILD_DATE is the build date
-- BUILD_TIME is the build time
-- GIT_SHA is the git SHA corresponding to the code used for building
+- ``CINAME`` the name of the CI
+- ``BUILD_DATE`` is the build date
+- ``BUILD_TIME`` is the build time
+- ``GIT_SHA is`` the git SHA corresponding to the code used for building
 
 ### Example
 
-The ``webserver`` service in master branch with commit ``752ef...`` will be built by ``github`` actions CI on ``2020/08/31`` at ``12:36`` and therefore the image is named as:
+The ``webserver`` service in *master* branch with commit ``752ef...`` will be built by *github actions*  CI on ``2020/08/31`` at ``12:36`` and therefore the image is named as:
 
 - ``itisfoundation/webserver:master-github-v2.0.1-2020-08-31--12-36.752ef50f3babb6537580c0e03b85b9a8209bbf10``
 - ``itisfoundation/webserver:master-github-latest``
 
 ## Staging process
 
-A staging version of simcore is like a pre-released version, that is marked as such on the master branch by leveraging Github pre-release tagging mechanism. The CI is triggered and will pull the marked docker images (by using the given git SHA or latest master build), and tag them as staging images.
-Each docker image are renamed as:
+A staging version of simcore is a *pre-released* version that is marked as such on the *master* branch by leveraging *Github*  pre-release tagging mechanism. The CI is triggered and will pull the marked docker images (by using the given git SHA or latest *master* build), and tag them as staging images.
+Therefore, each docker image are renamed as:
 
-- itisfoundation/[image_name]:staging-[CINAME]-latest
-- itisfoundation/[image_name]:staging-[CINAME]-staging_[BUILD_NAMEVERSION]-[BUILD_DATE]--[BUILD_TIME].[GIT_SHA]
+- ``itisfoundation/[image_name]:staging-[CINAME]-latest``
+- ``itisfoundation/[image_name]:staging-[CINAME]-staging_[BUILD_NAMEVERSION]-[BUILD_DATE]--[BUILD_TIME].[GIT_SHA]``
 
 with:
 
-- CINAME the name of the CI
-- BUILD_NAMEVERSION is a one word name and a number (e.g. DaJia0, Dajia1, ...)
-- BUILD_DATE is the build date
-- BUILD_TIME is the build time
-- GIT_SHA is the git SHA corresponding to the code used for building
+- ``CINAME`` the name of the CI
+- ``BUILD_NAMEVERSION`` is a one word name and a number (e.g. DaJia0, Dajia1, ...)
+- ``BUILD_DATE`` is the build date
+- ``BUILD_TIME`` is the build time
+- ``GIT_SHA`` is the git SHA corresponding to the code used for building
 
 ### Staging example
 
-Just before the review of the ``DAJIA`` sprint we release a staging version ``v1.0.0``, the commit ``752ef...`` from above is tagged as stage and the ``github`` actions CI on ``2020/09/01`` at ``17:30``.
+Just before the review of the ``DAJIA`` sprint we release a staging version ``v1.0.0``, the commit ``752ef...`` from above is tagged as stage and the *Github actions*  CI on ``2020/09/01`` at ``17:30``.
 
 - ``itisfoundation/webserver:staging-github-stage_DAJIA1-2020-09-01--17-30.752ef50f3babb6537580c0e03b85b9a8209bbf10``
 - ``itisfoundation/webserver:staging-github-latest``
@@ -55,34 +55,34 @@ then after the review we do a couple of additions and re-release staging ``DAJIA
 
 ### Instructions to generate a staging release
 
-1. Generate Github release tag
+1. Generate *Github*  release tag
 
   ```bash
   git clone https://github.com/ITISFoundation/osparc-simcore.git
   cd osparc-simcore
   make release-staging name=SPRINTNAME version=VERSION (git_sha=OPTIONAL)
   ```
-
 2. Adjust the list of changes if needed
 3. Press the **Publish release** button
 4. The CI will be automatically triggered and will deploy the staging release
 
+
 ## Release process
 
-A released version of simcore, that is marked as such on the master branch by leveraging Github release tagging mechanism. The CI is triggered and will pull the marked staging docker images (by using the given git SHA or the latest staging images), and tag them as release images.
+A released version of simcore, that is marked as such on the *master* branch by leveraging *Github*  release tagging mechanism. The CI is triggered and will pull the marked staging docker images (by using the given git SHA or the latest staging images), and tag them as release images.
 **NOTE:** A release version is ALWAYS preceded by a staging version. The CI will fail if it does not find the corresponding staging version.
 Each docker build marked as released are tagged as:
 
-- itisfoundation/[image_name]:release-[CINAME]-latest
-- itisfoundation/[image_name]:release-[CINAME]-v[RELEASE_VERSION]-[BUILD_DATE]--[BUILD_TIME].GIT_SHA
+- ``itisfoundation/[image_name]:release-[CINAME]-latest``
+- ``itisfoundation/[image_name]:release-[CINAME]-v[RELEASE_VERSION]-[BUILD_DATE]--[BUILD_TIME].GIT_SHA``
 
 with:
 
-- CINAME the name of the CI
-- RELEASE_VERSION is a version number following semantic versioning (e.g. 1.0.0, 1.2.0, 1.2.1, ...)
-- BUILD_DATE is the build date
-- BUILD_TIME is the build time
-- GIT_SHA is the git SHA corresponding to the code used for building
+- ``CINAME`` the name of the CI
+- ``RELEASE_VERSION`` is a version number following semantic versioning (e.g. 1.0.0, 1.2.0, 1.2.1, ...)
+- ``BUILD_DATE`` is the build date
+- ``BUILD_TIME`` is the build time
+- ``GIT_SHA`` is the git SHA corresponding to the code used for building
 
 ### Release example
 
@@ -93,7 +93,7 @@ The team decides to release to production the lastest staging version of ``DAJIA
 
 ### Instructions to generate a release
 
-1. Generate Github release tag
+1. Generate *Github*  release tag
 
   ```bash
   git clone https://github.com/ITISFoundation/osparc-simcore.git
@@ -109,10 +109,10 @@ The team decides to release to production the lastest staging version of ``DAJIA
 
 A hotfix is **ALWAYS made from an already released version**. A branch is created from the tagged release version (must be named hotfix_v*) and the fix is implemented there following usual best practices. On each commit in that branch the CI is triggered and will generate the following images in Dockerhub:
 
-- itisfoundation/[image_name]:hotfix-[CINAME]-latest
-- itisfoundation/[image_name]:hotfix-[CINAME]-[BUILD_DATE]--[BUILD_TIME].[GIT_SHA]
+- ``itisfoundation/[image_name]:hotfix-[CINAME]-latest``
+- ``itisfoundation/[image_name]:hotfix-[CINAME]-[BUILD_DATE]--[BUILD_TIME].[GIT_SHA]``
 
-Once ready, the release-hotfix process starts by leveraging Github release mechanism. The CI will trigger again and pull the docker images (based on git SHA or latest hotfix image) and push a new release version.
+Once ready, the release-hotfix process starts by leveraging *Github*  release mechanism. The CI will trigger again and pull the docker images (based on git SHA or latest hotfix image) and push a new release version.
 
 Each docker build marked as released are tagged as described in the Release process.
 
@@ -127,7 +127,7 @@ A bug was found in version 1.2.0 of the simcore stack. The team decides to fix i
 
 ### Instructions to generate a hotfix release
 
-1. Generate Github release tag
+1. Generate *Github*  release tag
 
   ```bash
   git clone https://github.com/ITISFoundation/osparc-simcore.git

services/catalog/src/simcore_service_catalog/services/director.py

@@ -69,12 +69,17 @@ def _unenvelope_or_raise_error(resp: Response) -> Dict:
         return data or {}
 
     @functools.wraps(request_func)
-    async def request_wrapper(self: "AuthSession", path: str, *args, **kwargs):
+    async def request_wrapper(self: "DirectorApi", path: str, *args, **kwargs):
         try:
             normalized_path = path.lstrip("/")
             resp = await request_func(self, path=normalized_path, *args, **kwargs)
         except Exception as err:
-            logger.exception("Failed to put %s%s", self.client.base_url, path)
+            logger.exception(
+                "Failed request %s to %s%s",
+                request_func.__name__,
+                self._client.base_url,
+                path,
+            )
             raise HTTPException(status.HTTP_503_SERVICE_UNAVAILABLE) from err
 
         return _unenvelope_or_raise_error(resp)