@GitHK review: add exceptions

Author: sanderegg

services/storage/src/simcore_service_storage/modules/celery/client.py

@@ -11,6 +11,7 @@
 from models_library.progress_bar import ProgressReport
 from pydantic import ValidationError
 from servicelib.logging_utils import log_context
+from simcore_service_storage.exceptions.errors import ConfigurationError
 
 from .models import TaskContext, TaskID, TaskState, TaskStatus, TaskUUID
 
@@ -128,7 +129,7 @@ def _get_completed_task_uuids(self, task_context: TaskContext) -> set[TaskUUID]:
         search_key = _CELERY_TASK_META_PREFIX + _build_task_id_prefix(task_context)
         backend_client = self._celery_app.backend.client
         if hasattr(backend_client, "keys") and (
-            keys := backend_client.keys(search_key + "*")
+            keys := backend_client.keys(f"{search_key}*")
         ):
             return {
                 TaskUUID(
@@ -148,8 +149,8 @@ def _get_completed_task_uuids(self, task_context: TaskContext) -> set[TaskUUID]:
                         )
                     )
             return found_keys
-
-        return set()
+        msg = f"Unsupported backend {self._celery_app.backend.__class__.__name__}"
+        raise ConfigurationError(msg=msg)
 
     @make_async()
     def get_task_uuids(self, task_context: TaskContext) -> set[TaskUUID]:

services/storage/tests/unit/test_rpc_handlers_simcore_s3.py

@@ -465,7 +465,7 @@ async def _fake_download_to_file_or_raise(session, url, dest_path):
         )
     ],
 )
-@pytest.mark.parametrize("num_concurrent_calls", [1, 20])
+@pytest.mark.parametrize("num_concurrent_calls", [1, 20], ids=str)
 async def test_create_and_delete_folders_from_project(
     set_log_levels_for_noisy_libraries: None,
     initialized_app: FastAPI,