test fixed

Author: sanderegg

services/director-v2/tests/unit/with_dbs/comp_scheduler/test_scheduler_dask.py

@@ -2048,7 +2048,7 @@ async def test_pipeline_with_on_demand_cluster_with_not_ready_backend_waits(
     "get_or_create_exception",
     [ClustersKeeperNotAvailableError],
 )
-async def test_pipeline_with_on_demand_cluster_with_no_clusters_keeper_fails(
+async def test_pipeline_with_on_demand_cluster_with_no_clusters_keeper_waits(
     with_disabled_auto_scheduling: mock.Mock,
     with_disabled_scheduler_publisher: mock.Mock,
     initialized_app: FastAPI,
@@ -2100,8 +2100,8 @@ async def test_pipeline_with_on_demand_cluster_with_no_clusters_keeper_fails(
         expected_progress=None,
         run_id=run_in_db.run_id,
     )
-    # now it should switch to failed, the run still runs until the next iteration
-    expected_failed_tasks = [
+    # now it should switch to waiting for cluster and waits
+    expected_waiting_for_cluster_tasks = [
         published_project.tasks[1],
         published_project.tasks[3],
     ]
@@ -2116,7 +2116,7 @@ async def test_pipeline_with_on_demand_cluster_with_no_clusters_keeper_fails(
     await assert_comp_runs(
         sqlalchemy_async_engine,
         expected_total=1,
-        expected_state=RunningState.FAILED,
+        expected_state=RunningState.WAITING_FOR_CLUSTER,
         where_statement=and_(
             comp_runs.c.user_id == published_project.project.prj_owner,
             comp_runs.c.project_uuid == f"{published_project.project.uuid}",
@@ -2130,22 +2130,24 @@ async def test_pipeline_with_on_demand_cluster_with_no_clusters_keeper_fails(
     await assert_comp_tasks_and_comp_run_snapshot_tasks(
         sqlalchemy_async_engine,
         project_uuid=published_project.project.uuid,
-        task_ids=[t.node_id for t in expected_failed_tasks],
-        expected_state=RunningState.FAILED,
-        expected_progress=1.0,
+        task_ids=[t.node_id for t in expected_waiting_for_cluster_tasks],
+        expected_state=RunningState.WAITING_FOR_CLUSTER,
+        expected_progress=None,
         run_id=run_in_db.run_id,
     )
-    # again will not re-trigger the call to clusters-keeper
+    # again will trigger the call again
     await scheduler_api.apply(
         user_id=run_in_db.user_id,
         project_id=run_in_db.project_uuid,
         iteration=run_in_db.iteration,
     )
-    mocked_get_or_create_cluster.assert_not_called()
+    mocked_get_or_create_cluster.assert_called()
+    assert mocked_get_or_create_cluster.call_count == 1
+    mocked_get_or_create_cluster.reset_mock()
     await assert_comp_runs(
         sqlalchemy_async_engine,
         expected_total=1,
-        expected_state=RunningState.FAILED,
+        expected_state=RunningState.WAITING_FOR_CLUSTER,
         where_statement=and_(
             comp_runs.c.user_id == published_project.project.prj_owner,
             comp_runs.c.project_uuid == f"{published_project.project.uuid}",
@@ -2159,9 +2161,9 @@ async def test_pipeline_with_on_demand_cluster_with_no_clusters_keeper_fails(
     await assert_comp_tasks_and_comp_run_snapshot_tasks(
         sqlalchemy_async_engine,
         project_uuid=published_project.project.uuid,
-        task_ids=[t.node_id for t in expected_failed_tasks],
-        expected_state=RunningState.FAILED,
-        expected_progress=1.0,
+        task_ids=[t.node_id for t in expected_waiting_for_cluster_tasks],
+        expected_state=RunningState.WAITING_FOR_CLUSTER,
+        expected_progress=None,
         run_id=run_in_db.run_id,
     )