fixing fakes

Author: pcrespov

packages/models-library/tests/test_services_types.py

@@ -44,10 +44,14 @@ def test_get_resource_tracking_run_id_for_dynamic():
     )
 
 
-def test_faker_factories_random_service_key_and_version_are_in_sync():
+@pytest.mark.parametrize(
+    "service_key, service_version",
+    [(random_service_key(), random_service_version()) for _ in range(10)],
+)
+def test_service_key_and_version_are_in_sync(
+    service_key: ServiceKey, service_version: ServiceVersion
+):
+    TypeAdapter(ServiceKey).validate_python(service_key)
+    TypeAdapter(ServiceVersion).validate_python(service_version)
 
-    for _ in range(10):
-        key = random_service_key()
-        version = random_service_version()
-        TypeAdapter(ServiceKey).validate_python(key)
-        TypeAdapter(ServiceVersion).validate_python(version)
+    assert service_key.startswith("simcore/services/")

packages/pytest-simcore/src/pytest_simcore/helpers/faker_factories.py

@@ -26,11 +26,12 @@
 
 
 def random_service_key(fake: Faker = DEFAULT_FAKER, *, name: str | None = None) -> str:
-    return f"simcore/services/{fake.random_element(['dynamic', 'comp', 'frontend'])}/{name or fake.name().lower().replace(' ', '')}"
+    suffix = fake.unique.word() if name is None else name
+    return f"simcore/services/{fake.random_element(['dynamic', 'comp', 'frontend'])}/{suffix}"
 
 
 def random_service_version(fake: Faker = DEFAULT_FAKER) -> str:
-    return ".".join([str(fake.pyint()) for _ in range(3)])
+    return ".".join([str(fake.pyint(0, 100)) for _ in range(3)])
 
 
 def random_icon_url(fake: Faker):