fix tests and pylint

Author: Andrei Neagu

packages/simcore-sdk/src/simcore_sdk/node_ports_common/dbmanager.py

@@ -73,6 +73,7 @@ async def _create_db_engine() -> aiopg.sa.Engine:
         settings = NodePortsSettings.create_from_envs()
         dsn = DataSourceName(
             application_name=f"{__name__}_{socket.gethostname()}_{os.getpid()}",
+            # pylint:disable=no-member
             database=settings.POSTGRES_SETTINGS.POSTGRES_DB,
             user=settings.POSTGRES_SETTINGS.POSTGRES_USER,
             password=settings.POSTGRES_SETTINGS.POSTGRES_PASSWORD.get_secret_value(),

packages/simcore-sdk/src/simcore_sdk/node_ports_common/storage_endpoint.py

@@ -8,13 +8,15 @@
 def is_storage_secure() -> bool:
     settings = NodePortsSettings.create_from_envs()
     node_ports_storage_auth = settings.NODE_PORTS_STORAGE_AUTH
+    # pylint:disable=no-member
     is_secure: bool = node_ports_storage_auth.STORAGE_SECURE
     return is_secure
 
 
 @lru_cache
 def get_base_url() -> str:
     settings = NodePortsSettings.create_from_envs()
+    # pylint:disable=no-member
     base_url: str = settings.NODE_PORTS_STORAGE_AUTH.api_base_url
     return base_url
 
@@ -24,6 +26,7 @@ def get_basic_auth() -> BasicAuth | None:
     settings = NodePortsSettings.create_from_envs()
     node_ports_storage_auth = settings.NODE_PORTS_STORAGE_AUTH
 
+    # pylint:disable=no-member
     if node_ports_storage_auth.auth_required:
         assert node_ports_storage_auth.STORAGE_USERNAME is not None  # nosec
         assert node_ports_storage_auth.STORAGE_PASSWORD is not None  # nosec

packages/simcore-sdk/tests/unit/test_node_ports_v2_links.py

@@ -1,8 +1,7 @@
-from typing import Dict
 from uuid import uuid4
 
 import pytest
-from pydantic import TypeAdapter, ValidationError
+from pydantic import ValidationError
 from simcore_sdk.node_ports_v2.links import DownloadLink, FileLink, PortLink
 
 
@@ -23,7 +22,7 @@ def test_valid_port_link():
         {"nodeUuid": f"{uuid4()}", "output": "some:key"},
     ],
 )
-def test_invalid_port_link(port_link: Dict[str, str]):
+def test_invalid_port_link(port_link: dict[str, str]):
     with pytest.raises(ValidationError):
         PortLink(**port_link)
 
@@ -36,7 +35,7 @@ def test_invalid_port_link(port_link: Dict[str, str]):
         {"label": "some stuff"},
     ],
 )
-def test_invalid_download_link(download_link: Dict[str, str]):
+def test_invalid_download_link(download_link: dict[str, str]):
     with pytest.raises(ValidationError):
         DownloadLink(**download_link)
 
@@ -49,6 +48,6 @@ def test_invalid_download_link(download_link: Dict[str, str]):
         {"path": "/somefile/blahblah:"},
     ],
 )
-def test_invalid_file_link(file_link: Dict[str, str]):
+def test_invalid_file_link(file_link: dict[str, str]):
     with pytest.raises(ValidationError):
         FileLink(**file_link)

packages/simcore-sdk/tests/unit/test_node_ports_v2_nodeports_v2.py

@@ -3,7 +3,6 @@
 # pylint:disable=redefined-outer-name
 # pylint:disable=protected-access
 
-import asyncio
 from pathlib import Path
 from typing import Any, Callable
 from unittest.mock import AsyncMock
@@ -230,10 +229,7 @@ async def test_node_ports_v2_packages(
 @pytest.fixture
 def mock_port_set(mocker: MockFixture) -> None:
     async def _always_raise_error(*args, **kwargs):
-        async def _i_raise_errors():
-            raise ValidationError("invalid")
-
-        return asyncio.create_task(_i_raise_errors())
+        raise ValidationError.from_exception_data(title="Just a test", line_errors=[])
 
     mocker.patch(
         "simcore_sdk.node_ports_v2.port.Port._set", side_effect=_always_raise_error
@@ -278,4 +274,5 @@ async def _mock_callback(*args, **kwargs):
                     + list(original_outputs.values())
                 },
                 progress_bar=progress_bar,
+                outputs_callbacks=None,
             )